-
Notifications
You must be signed in to change notification settings - Fork 38.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create node_e2e test for ephemeral containers #103372
Conversation
/remove-kind feature |
xref KEP: kubernetes/enhancements#277 |
/assign @cynepco3hahue |
Hi @cynepco3hahue, will you have time to review this new test? |
@verb Sure, will take a look today. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@verb Do we have a separate job for this test or does the test run as part of some existing job?
@cynepco3hahue thanks for the review!
It runs with the alpha features test. Do you think we should include it elsewhere as well? |
@ehashman could you help me find an approver for this node e2e test? It had lgtm but lost it when I fixed a merge conflict. Thanks! |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dims, verb The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
Hi @cynepco3hahue, this PR is approved now, but we lost your LGTM to resolve a merge conflict. Could you please take another look to see if it still looks good? Thanks! |
/priority important-soon |
/test pull-kubernetes-e2e-gce-alpha-features |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few nits. Also started test, to make sure it's ready for review. I'm curious if the timeout of one minute is sufficient in CI environment
@verb: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Co-authored-by: Sergey Kanzhelev <S.Kanzhelev@live.com>
@SergeyKanzhelev @cynepco3hahue @ehashman Please help me meet sig-nodes soft deadline for feature graduation by giving an LGTM on this new e2e test that has been open since June, previously had LGTM, already has approval, and is blocking #105405. This PR should be safe to merge because it only modifies |
/lgtm |
What type of PR is this?
/kind feature
/sig node
What this PR does / why we need it:
This adds an node e2e test for creating ephemeral containers.
Which issue(s) this PR fixes:
Fixes #85545
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: