New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ephemeral Containers #277

Open
verb opened this Issue Apr 25, 2017 · 48 comments

Comments

@verb
Contributor

verb commented Apr 25, 2017

Feature Description

  • One-line feature description (can be used as a release note): Support advanced troubleshooting of running pods by running a new container image in shared pod namespaces.
  • Primary contact (assignee): @verb
  • Responsible SIGs: sig-node
  • Design proposal link (community repo): Troubleshoot Running Pods (pending update: kubernetes/community#1269)
  • Link to e2e and/or unit tests:
  • Reviewer(s) - (for LGTM) recommend having 2+ reviewers (at least one from code-area OWNERS file) agreed to review. Reviewers from multiple companies preferred: @dashpole @yujuhong
  • Approver (likely from SIG/area to which feature belongs): @dchen1107
  • Feature target (which target equals to which milestone):
    • Alpha release target (1.12)
    • Beta release target (x.y)
    • Stable release target (x.y)
@liggitt

This comment has been minimized.

Member

liggitt commented May 23, 2017

@verb

This comment has been minimized.

Contributor

verb commented Jun 1, 2017

@dchen1107 @idvoretskyi This should move to 1.8 milestone & features.

/sig api-machinery

@verb verb changed the title from Pod Troubleshooting to Debug Containers Jun 1, 2017

@idvoretskyi idvoretskyi modified the milestones: next-milestone, v1.7 Jun 1, 2017

@idvoretskyi idvoretskyi removed this from In Progress in Kubernetes 1.7 features Jun 1, 2017

@idvoretskyi

This comment has been minimized.

Member

idvoretskyi commented Jun 1, 2017

@verb thanks, updated.

@calebamiles calebamiles modified the milestones: 1.8, next-milestone Jul 25, 2017

@pwittrock

This comment has been minimized.

Member

pwittrock commented Aug 17, 2017

@verb Is this still targeted for 1.8?

@verb

This comment has been minimized.

Contributor

verb commented Aug 18, 2017

@pwittrock No, let's bump to 1.9

@pwittrock pwittrock removed this from the 1.8 milestone Sep 7, 2017

@idvoretskyi

This comment has been minimized.

Member

idvoretskyi commented Oct 2, 2017

@verb still on track for 1.9?

@idvoretskyi idvoretskyi added this to the next-milestone milestone Oct 2, 2017

@verb

This comment has been minimized.

Contributor

verb commented Oct 7, 2017

@verb

This comment has been minimized.

Contributor

verb commented Oct 24, 2017

/remove-sig api-machinery
/sig auth

@radu-matei

This comment has been minimized.

radu-matei commented Jan 19, 2018

Hi!
Is there anyone actively working on this?

I would really like to start contributing on it (realistically starting next week or so).

@verb

This comment has been minimized.

Contributor

verb commented Jan 19, 2018

@radu-matei Yes, I'm actively working on it. I have some PRs lined up but we haven't quite finalized the API yet, see kubernetes/community#1269.

I'd love to have some help here, of course. Was there a particular area to which you'd like to contribute?

@radu-matei

This comment has been minimized.

radu-matei commented Jan 20, 2018

@verb I probably can work on kubectl right away, but I would also very much want to understand the API server and kubelet.

@verb

This comment has been minimized.

Contributor

verb commented Aug 21, 2018

Hi @zparnold, I don't have permission to update the spreadsheet, but I added a comment. We won't need docs for this release as all we're planning is an API update.

@zparnold

This comment has been minimized.

Member

zparnold commented Aug 25, 2018

@verb

This comment has been minimized.

Contributor

verb commented Aug 27, 2018

yes, that's my plan.

@zparnold

This comment has been minimized.

Member

zparnold commented Aug 27, 2018

@loewenstein

This comment has been minimized.

loewenstein commented Sep 9, 2018

@verb what is the current plan for delivering this feature? 1.12? 1.13? Later?

@verb

This comment has been minimized.

Contributor

verb commented Sep 10, 2018

@loewenstein we made progress, but not enough for 1.12. Now we're aiming for 1.13.

@kacole2

This comment has been minimized.

Contributor

kacole2 commented Sep 10, 2018

@verb thanks for the update. this has been removed from the tracking sheet. Please update the original issue when you get a chance.

/milestone 1.13

@k8s-ci-robot

This comment has been minimized.

Contributor

k8s-ci-robot commented Sep 10, 2018

@kacole2: The provided milestone is not valid for this repository. Milestones in this repository: [v1.12, v1.13, v1.14]

Use /milestone clear to clear the milestone.

In response to this:

@verb thanks for the update. this has been removed from the tracking sheet. Please update the original issue when you get a chance.

/milestone 1.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kacole2

This comment has been minimized.

Contributor

kacole2 commented Sep 10, 2018

/milestone clear

@k8s-ci-robot k8s-ci-robot removed this from the v1.12 milestone Sep 10, 2018

@k8s-ci-robot

This comment was marked as resolved.

Contributor

k8s-ci-robot commented Sep 10, 2018

@kacole2: The provided milestone is not valid for this repository. Milestones in this repository: [v1.12, v1.13, v1.14]

Use /milestone clear to clear the milestone.

In response to this:

/milestone 1.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mistyhacks

This comment has been minimized.

mistyhacks commented Sep 10, 2018

/milestone v1.13

@k8s-ci-robot

This comment has been minimized.

Contributor

k8s-ci-robot commented Sep 10, 2018

@mistyhacks: You must be a member of the kubernetes/kubernetes-milestone-maintainers github team to set the milestone.

In response to this:

/milestone v1.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mistyhacks

This comment has been minimized.

mistyhacks commented Sep 10, 2018

For heavens sake.

@kacole2

This comment has been minimized.

Contributor

kacole2 commented Sep 10, 2018

/milestone v1.13

think that will do it :)

@k8s-ci-robot k8s-ci-robot added this to the v1.13 milestone Sep 10, 2018

@kacole2

This comment has been minimized.

Contributor

kacole2 commented Oct 8, 2018

@verb just checking in to see if you feel confident this will make it to v1.13

This release is targeted to be more ‘stable’ and will have an aggressive timeline. Please only include this enhancement if there is a high level of confidence it will meet the following deadlines:

  • Docs (open placeholder PRs): 11/8
  • Code Slush: 11/9
  • Code Freeze Begins: 11/15
  • Docs Complete and Reviewed: 11/27

Please take a moment to update the milestones on your original post for future tracking and ping @kacole2 if it needs to be included in the 1.13 Enhancements Tracking Sheet

Thanks!

@verb

This comment has been minimized.

Contributor

verb commented Oct 9, 2018

ack, will sync up with reviewers and update

@spiffxp

This comment has been minimized.

Member

spiffxp commented Oct 16, 2018

@verb What issues or PR's are related to this work?

Guessing:

Is "Ephemeral Containers" a better name for this enhancement?

@verb

This comment has been minimized.

Contributor

verb commented Oct 17, 2018

Hi @spiffxp,

@verb What issues or PR's are related to this work?

Guessing:

Correct, these are the current issues & PRs. Don't worry about kubernetes/kubernetes#53189 as it's no longer relevant.

Is "Ephemeral Containers" a better name for this enhancement?

Probably, yes. Some people still know it as Debug Containers, but the API will refer exclusively to Ephemeral Containers, so I've updated the feature title.

@guineveresaenger

This comment has been minimized.

guineveresaenger commented Oct 22, 2018

@verb - I left some comments on the related PRs, but as Enhancements Freeze is tomorrow we really need a status update on kubernetes/kubernetes#59484. If there is no communication after COB tomorrow, an exception will be required to add it back to the milestone. Please let me or Enhancements Lead @kacole2 know where we stand. Thanks!

@verb

This comment has been minimized.

Contributor

verb commented Oct 22, 2018

@guineveresaenger Thanks for following up. I expect this API review to take a while yet. If it's time to decide now then we should remove it from 1.13.

There is a kubelet clean-up PR related to this feature that I'd like to merge for 1.13, though. It's small, fits into the stability theme, and I'm confident we can have to reviewed by slush. Does this feature need to remain in the 1.13 milestone in order for that to merge?

@kacole2

This comment has been minimized.

Contributor

kacole2 commented Oct 22, 2018

@verb is the kubelet clean-up PR considered part of this as an umbrella issue? or should it be tracked as a separate enhancement? Meaning it would need docs, review, tracking, etc.

@verb

This comment has been minimized.

Contributor

verb commented Oct 22, 2018

@kacole2 it's not user facing, so there would be no docs or tracking. It's part of this feature, but I could open a separate issue for it in kubernetes/kubernetes if that would help.

@kacole2

This comment has been minimized.

Contributor

kacole2 commented Oct 22, 2018

@verb i think it's safe to assume that it's just a small component that has no effect on this umbrella feature moving to a stage. However, any new feature going into k/k should be attached to an enhancement issue. If it needs to be tracked in some manner then open a new issue. We can go ahead and defer this issue to the next milestone for now. thanks for the prompt reply!
/milestone v1.14

@kacole2 kacole2 modified the milestones: v1.13, v1.14 Oct 22, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment