Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore ability to print long strings #103574

Merged
merged 1 commit into from Jul 8, 2021
Merged

Restore ability to print long strings #103574

merged 1 commit into from Jul 8, 2021

Conversation

liggitt
Copy link
Member

@liggitt liggitt commented Jul 8, 2021

What type of PR is this?

/kind bug

What this PR does / why we need it:

Reverts the long string truncation added in #103514 until it can be done in a less invasive or more adaptive way. Kept the multi-line truncation.

NONE

/assign @soltysh
/sig cli

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. sig/cli Categorizes an issue or PR as relevant to SIG CLI. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jul 8, 2021
@liggitt liggitt mentioned this pull request Jul 8, 2021
Merged
@liggitt liggitt added this to the v1.22 milestone Jul 8, 2021
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 8, 2021
@soltysh soltysh mentioned this pull request Jul 8, 2021
Closed
@smarterclayton
Copy link
Contributor

I agree I would have held #103514 because that breaks the output contracts for end users using the cli (not forward compatible)

@soltysh
Copy link
Contributor

soltysh commented Jul 8, 2021

I agree I would have held #103514 because that breaks the output contracts for end users using the cli (not forward compatible)

But having multi-line breaking the output isn't preferred I guess, I proposed alternative dropping long lines in #103582

soltysh
soltysh approved these changes Jul 8, 2021
View reviewed changes
Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/retest

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 8, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@liggitt liggitt added kind/regression Categorizes issue or PR as related to a regression from a prior release. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. triage/accepted Indicates an issue or PR is ready to be actively worked on. labels Jul 8, 2021
@k8s-ci-robot k8s-ci-robot removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jul 8, 2021
@k8s-ci-robot k8s-ci-robot merged commit 97d6e4a into kubernetes:master Jul 8, 2021
@liggitt liggitt deleted the restore-long-printing branch July 8, 2021 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soltysh soltysh soltysh approved these changes

@pwittrock pwittrock Awaiting requested review from pwittrock

Assignees

@soltysh soltysh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. kind/regression Categorizes issue or PR as related to a regression from a prior release. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/cli Categorizes an issue or PR as relevant to SIG CLI. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.22
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@liggitt @smarterclayton @soltysh @k8s-ci-robot