Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose BindPodsQps and BindPodsBurst as cmd line flags #10377

Closed
HaiyangDING opened this issue Jun 26, 2015 · 9 comments
Closed

Expose BindPodsQps and BindPodsBurst as cmd line flags #10377

HaiyangDING opened this issue Jun 26, 2015 · 9 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. priority/backlog Higher priority than priority/awaiting-more-evidence. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling.

Comments

@HaiyangDING
Copy link

There is a TODO in the scheduler/factory stating that BindPodsQps and BindPodsBurst should be exposed as cmd line flags.

I would like to implement this, if no one is currently working on it.

@mbforbes mbforbes added priority/backlog Higher priority than priority/awaiting-more-evidence. team/master labels Jun 26, 2015
@mbforbes
Copy link
Contributor

@HaiyangDING can you please find authors who have touched the code recently (check out GitHub's history) and then @ mention them here directly? They'll be able to tell you whether we'll likely accept PRs for these fixes in the next couple weeks (we're pushing to 1.0 so are generally only accepting work on 1.0 features, tests, documentation, or bug fixes). Thank you--please ping if you need help!

@HaiyangDING
Copy link
Author

@mbforbes , I will look up the history to see if I can find the author.

Besides, I am going to see if I can do anything for 1.0. Many thanks to your suggestion!

@HaiyangDING
Copy link
Author

@bprashanth ,

Hi, I saw in the Git history that you have added limitation to pod burst qps and pod binding rate at 4004a68. In the patch, it is mentioned that BindPodsQps and BindPodsBurst should be exposed to cmd line flags. If you do not mind, may I send a PR to implement this? I just want to make some contribution to Kubernetes and have total respect of the work you have done:)

Regards

@bprashanth
Copy link
Contributor

@HaiyangDING out of curiosity, do you have a use case in mind? (Would you like to push the limit higher/lower?). I'm totally fine exposing it as a command line flag if you need it, note however that we're currently in a code freeze working toward our 1.0 release (https://groups.google.com/forum/#!topic/kubernetes-announce/1voyC1d-T_o), so we might not be able to merge your pr right away.

@HaiyangDING
Copy link
Author

@bprashanth ,

Hi, I do not have a specific use case right away. I wanted to implement this simply because I saw a TODO when reading the code. Luckily enough, it happens that I have had some contribution to the scheduler cmd line(#6967), so I felt that I could make more contribution for the community:) That is all my motivation.

Besides, it is OK for me if the PR not be merged for some moment.

PS: I have already written relevant code and tested it already.

@k8s-github-robot k8s-github-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label May 31, 2017
@0xmichalis
Copy link
Contributor

@kubernetes/sig-node-feature-requests

@k8s-ci-robot k8s-ci-robot added sig/node Categorizes an issue or PR as relevant to SIG Node. kind/feature Categorizes issue or PR as related to a new feature. labels Jun 3, 2017
@k8s-github-robot k8s-github-robot removed the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Jun 3, 2017
@yujuhong yujuhong added sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. and removed sig/node Categorizes an issue or PR as relevant to SIG Node. labels Jun 3, 2017
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

Prevent issues from auto-closing with an /lifecycle frozen comment.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or @fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 26, 2017
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or @fejta.
/lifecycle rotten
/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jan 25, 2018
@fejta-bot
Copy link

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. priority/backlog Higher priority than priority/awaiting-more-evidence. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling.
Projects
None yet
Development

No branches or pull requests

9 participants