Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

job controller: don't mutate shared cache object #104129

Merged
merged 1 commit into from Sep 1, 2021

Conversation

adtac
Copy link
Member

@adtac adtac commented Aug 4, 2021

What type of PR is this?

/kind bug

What this PR does / why we need it:

Cherry pick of 0a21157

Which issue(s) this PR fixes:

Fixes #100551

Special notes for your reviewer:

cc @ialidzhikov @alculquicondor @ahg-g

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


/sig apps

@k8s-ci-robot k8s-ci-robot added do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. labels Aug 4, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.20 milestone Aug 4, 2021
@k8s-ci-robot k8s-ci-robot added sig/apps Categorizes an issue or PR as relevant to SIG Apps. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Aug 4, 2021
@adtac
Copy link
Member Author

adtac commented Aug 4, 2021

(Not using the cherry_pick_pull.sh script becase that PR has more than just the bug fix; you can't select specific commits with that shell script.)

@alculquicondor
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 4, 2021
@ialidzhikov
Copy link
Contributor

/assign @soltysh
for approval

@ialidzhikov
Copy link
Contributor

ping @soltysh @ahg-g
for approval

@ahg-g
Copy link
Member

ahg-g commented Aug 26, 2021

@kubernetes/release-managers

@ialidzhikov
Copy link
Contributor

@kubernetes/release-managers

@ahg-g , before tagging release managers, PR needs to be lgtm-ed and approve-ed by reviewers. Only after this release managers remove the do-not-merge/cherry-pick-not-approved label.

@ialidzhikov
Copy link
Contributor

@ahg-g currently this PR is missing approved label :)

@ahg-g
Copy link
Member

ahg-g commented Aug 26, 2021

Right, only @soltysh can approve, but having it in the queue for release managers from now is good too.

@ahg-g
Copy link
Member

ahg-g commented Aug 26, 2021

/assign @janetkuo

since Maciek may not be available

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 26, 2021
@ialidzhikov
Copy link
Contributor

/cc @kubernetes/release-managers

@k8s-ci-robot k8s-ci-robot requested a review from a team August 30, 2021 14:12
@cpanato
Copy link
Member

cpanato commented Sep 1, 2021

/priority important-soon
/triage accepted

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Sep 1, 2021
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@cpanato cpanato added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Sep 1, 2021
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Sep 1, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adtac, cpanato, janetkuo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit c42cf17 into kubernetes:release-1.20 Sep 1, 2021
k8s-ci-robot added a commit that referenced this pull request Sep 1, 2021
…9-origin-release-1.19

Automated cherry pick of #104129: job controller: don't mutate shared cache object
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/apps Categorizes an issue or PR as relevant to SIG Apps. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants