Fix using variables in the loop in vsphere_util

[skyguard1]

What type of PR is this?

/kind bug

What this PR does / why we need it:

Use loop variables from within func literals in defer and go statements. Such variables might have unexpected values because they are not copied to func literals, and the func literals in defer and go are not executed immediately.
For more information about closures and goroutines, see https://golang.org/doc/faq#closures_and_goroutines, thanks

NONE

[k8s-ci-robot]

Hi @skyguard1. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[binacs]

/ok-to-test

[cheftako]

/assign @gnufied

[gnufied]

/lgtm

[gnufied]

/priority important-soon
/triage accepted

[gnufied]

lets merge this and backport to older releases as well?

[cheftako]

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cheftako, skyguard1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• staging/src/k8s.io/legacy-cloud-providers/OWNERS [cheftako]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-triage-robot]

The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass.

This bot retests PRs for certain kubernetes repos according to the following rules:

• The PR does have any do-not-merge/* labels
• The PR does not have the needs-ok-to-test label
• The PR is mergeable (does not have a needs-rebase label)
• The PR is approved (has cncf-cla: yes, lgtm, approved labels)
• The PR is failing tests required for merge

You can:

• Review the full test history for this PR
• Prevent this bot from retesting with /lgtm cancel or /hold
• Help make our tests less flaky by following our Flaky Tests Guide

/retest

[gnufied]

@skyguard1 do you mind creating backport requests for 1.20, 1.21 and 1.22 for this PR? Those are the versions where the issue is and I would like us to fix it.

[skyguard1]

@gnufied Of course I am willing to do this.It is my pleasure

[skyguard1]

@gnufied I found that the function BuildMissingVolumeNodeMap was added in 1.21. Do we need to add the new function in vsphere_util.go in 1.20, or do we not update the release-1.20 branch?

[skyguard1]

In my opinion, we don’t need to fix this on 1.20, right?

[gnufied]

@skyguard1 sure, whichever version has the related code - lets open PRs to fix it

[gnufied]

Can you also backport this PR to 1.22?

[skyguard1]

@gnufied Sure