Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1981187: Fix dangling volumes vsphere #890

Closed
wants to merge 5 commits into from
Closed

Bug 1981187: Fix dangling volumes vsphere #890

wants to merge 5 commits into from

Conversation

gnufied
Copy link
Member

@gnufied gnufied commented Aug 17, 2021 •
edited

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1981187

cc @openshift/sig-storage

Note to reviewers - this issue is already fixed in 4.7 onwards and hence does not require backports to those versions.

Pending backports in upstream:

kubernetes#104912 (against 1.19)
kubernetes#104910 (against 1.20)

@openshift-ci
Copy link

openshift-ci bot commented Aug 17, 2021

@gnufied: Bugzilla bug 1981187 is in a bug group that is not in the allowed groups for this repo.
Allowed groups for this repo are:

  • qe_staff
  • redhat

In response to this:

Bug 1981187: Fix dangling volumes vsphere

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the backports/validated-commits Indicates that all commits come to merged upstream PRs. label Aug 17, 2021
@openshift-ci-robot
Copy link

@gnufied: the contents of this pull request could be automatically validated.

The following commits are valid:

@gnufied
Copy link
Member Author

gnufied commented Aug 17, 2021

/bugzilla refresh

@openshift-ci
Copy link

openshift-ci bot commented Aug 17, 2021

@gnufied: Bugzilla bug 1981187 is in a bug group that is not in the allowed groups for this repo.
Allowed groups for this repo are:

  • qe_staff
  • redhat

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the vendor-update Touching vendor dir or related files label Aug 17, 2021
@openshift-ci openshift-ci bot requested review from marun and soltysh August 17, 2021 16:06
@gnufied
Copy link
Member Author

gnufied commented Aug 17, 2021

/retest
/test e2e-vsphere

@jsafrane
Copy link

/retest
/lgtm
I also checked that all the code is in 4.7 and 4.8.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 18, 2021
@gnufied
Copy link
Member Author

gnufied commented Aug 18, 2021

/retest

1 similar comment
@gnufied
Copy link
Member Author

gnufied commented Aug 20, 2021

/retest

@gnufied
Copy link
Member Author

gnufied commented Aug 20, 2021

/bugzilla refresh

@openshift-ci
Copy link

openshift-ci bot commented Aug 20, 2021

@gnufied: Bugzilla bug 1981187 is in a bug group that is not in the allowed groups for this repo.
Allowed groups for this repo are:

  • qe_staff
  • redhat

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@gnufied
Copy link
Member Author

gnufied commented Aug 20, 2021

/assign @deads2k @soltysh

@deads2k
Copy link

deads2k commented Aug 20, 2021

I don't see the 1.19 cherrypicks for these upstream.

  1. Fix dangling volumes from nodes not tracked by attach detach controller kubernetes/kubernetes#96689
  2. Add dangling volume check for vsphere kubernetes/kubernetes#96224
  3. Do not throw error when we can't get canonical path kubernetes/kubernetes#102892
  4. Fix vsphere disk detach failure kubernetes/kubernetes#95447

Comment kubernetes#96534 (comment) suggests a willingness to merge the upstream if they can be made to function in 1.19.

@deads2k
Copy link

deads2k commented Aug 23, 2021

I now see kubernetes#104485 and kubernetes#104485 just waiting on the patchmanager. You often have better luck getting them on slack.

Looks like just two more: kubernetes#96224 and kubernetes#96689

@gnufied
Copy link
Member Author

gnufied commented Aug 23, 2021

@deads2k yep. though they are dependent PRs, so I will have to wait for kubernetes#104485 before I can open another set of cherry-picks.

@gnufied
Copy link
Member Author

gnufied commented Sep 10, 2021

@deads2k so looks like kubernetes#104485 got merged. Since there are PR dependencies I have opened kubernetes#104910 against 1.20 and then I will have to open another PR against 1.19

@gnufied
Copy link
Member Author

gnufied commented Sep 10, 2021

Also backport for 1.19 - kubernetes#104912

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Sep 10, 2021
@openshift-ci-robot
Copy link

@gnufied: the contents of this pull request could be automatically validated.

The following commits are valid:

@openshift-ci
Copy link

openshift-ci bot commented Sep 10, 2021

@gnufied: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-vsphere cb49d50 link /test e2e-vsphere
ci/prow/e2e-agnostic-cmd 8bc803c link false /test e2e-agnostic-cmd

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@soltysh
Copy link
Member

soltysh commented Sep 13, 2021

@damemi fyi, since you're doing 4.6 bump

@jsafrane
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 21, 2021
@openshift-ci
Copy link

openshift-ci bot commented Sep 21, 2021

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: gnufied, jsafrane
To complete the pull request process, please ask for approval from deads2k after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@soltysh
Copy link
Member

soltysh commented Oct 6, 2021

kubernetes#104912 (against 1.19)

this just merged, so we'll get it for free with 1.19.15 release soon
/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 6, 2021
@gnufied
Copy link
Member Author

gnufied commented Oct 19, 2021

@soltysh FYI this is stil not merged and available in latest OCP-4.6.

@soltysh
Copy link
Member

soltysh commented Nov 5, 2021

@soltysh FYI this is stil not merged and available in latest OCP-4.6.

it'll be part of the next rounds of k8s bumps, iirc

@gnufied
Copy link
Member Author

gnufied commented Nov 5, 2021

/close

@gnufied gnufied closed this Nov 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marun marun Awaiting requested review from marun

@soltysh soltysh Awaiting requested review from soltysh

Assignees

@soltysh soltysh

@jsafrane jsafrane

@deads2k deads2k

Labels
backports/validated-commits Indicates that all commits come to merged upstream PRs. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged. vendor-update Touching vendor dir or related files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@gnufied @openshift-ci-robot @jsafrane @deads2k @soltysh @skyguard1