Fix nodeShutdownReason for node shutdown e2e

[wzshiming]

What type of PR is this?

/kind bug
/kind failing-test

What this PR does / why we need it:

Which issue(s) this PR fixes:

The #102840 modified the Status.Reason of shutdown, but e2e did not modify it accordingly.

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

NONE

[wzshiming]

/retest

[k8s-ci-robot]

@wzshiming: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-kubernetes-node-kubelet-serial	86acf3b	link	/test pull-kubernetes-node-kubelet-serial

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[SergeyKanzhelev]

/kind failing-test

[SergeyKanzhelev]

/assign @bobbypage

[ehashman]

/triage accepted
/priority backlog

[ehashman]

"GracefulNodeShutdown [Serial] [NodeAlphaFeature:GracefulNodeShutdown]" these tests are only running on their own CI tab and don't have a corresponding presubmit job. Can we just nix the NodeAlphaFeature selector and have them run as part of the serial job? This is beta now so the feature flag should be getting set, no? https://testgrid.k8s.io/sig-node-kubelet#kubelet-serial-gce-e2e-graceful-node-shutdown

I can't find any matching failures for this error message: https://storage.googleapis.com/k8s-triage/index.html?text=Expecting%20non-critcal%20pod%20to%20be%20shutdown%2C%20but%20it%27s%20not%20currently.

Test failures for this job all fail on waiting on /configz, so I think perhaps the jobs don't have a valid config to enable gracefulshutdown: https://prow.k8s.io/view/gs/kubernetes-jenkins/logs/ci-kubernetes-node-kubelet-serial-graceful-node-shutdown/1442540619628023808

/hold
/cc @bobbypage @rphillips @wgahnagl

[bobbypage]

@ehashman I agree we should eventually remove this separate job and move into serial. However, I think we should first ensure to get this job fully stable and working and only after migrate this into the existing serial tests.

I think we still need this change as described in #104540 (comment)

The waiting on configz failure is because the job relies on DynamicKubeletConfig, but it was turned off by default in #102966

I will send separate PR to turn it back on for this job for now, so we can get it back to green.

In terms of this change here
/lgtm

[bobbypage]

PR for enabling DynamicKubeletConfig to fix waiting on /configz errors - kubernetes/test-infra#23791

[bobbypage]

kubernetes/test-infra#23791 was merged to fix configz errors.

@ehashman can we remove the hold on this so we can start fixing the test? Thanks!

[bobbypage]

/assign @ehashman

[ehashman]

/lgtm
/approve

�[1mSTEP�[0m: Verifying that non-critical pods are shutdown
Oct 19 22:21:05.208: INFO: Expecting non-critcal pod to be shutdown, but it's not currently. Pod: "period-120", Pod Status Phase: "Running", Pod Status Reason: "Terminated"

from

https://prow.k8s.io/view/gs/kubernetes-jenkins/logs/ci-kubernetes-node-kubelet-serial-graceful-node-shutdown/1450585087165861888

[ehashman]

/hold cancel

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ehashman, wzshiming

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• test/e2e_node/OWNERS [ehashman]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment