Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix detach disk issue on deleting vmss node #104572

Merged
merged 1 commit into from Sep 10, 2021

Conversation

andyzhangx
Copy link
Member

@andyzhangx andyzhangx commented Aug 25, 2021

What type of PR is this?

/kind bug

What this PR does / why we need it:

fix detach disk issue on deleting node
This PR is a proceeding fix with #95177
There was error msg format change when vmss node is in deleting state, this PR tries to fix this issue to make sure detach disk return success on vmss node which is being deleting

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

current error msg is like following:

Operation for \"{volumeName:kubernetes.io/azure-disk//subscriptions/xxxx/resourceGroups/prdgxyusw1res-collabaks2/providers/Microsoft.Compute/disks/kubernetes-dynamic-pvc-bd431821-2dfe-4d8c-bd6d-2bc1fa7367e1 podName: nodeName:}\" failed. No retries permitted until 2021-08-18 20:15:37.594995668 +0000 UTC m=+183633.754026437 (durationBeforeRetry 500ms). Error: \"DetachVolume.Detach failed for volume \\\"pvc-bd431821-2dfe-4d8c-bd6d-2bc1fa7367e1\\\" (UniqueName: \\\"kubernetes.io/azure-disk//subscriptions/xxx/resourceGroups/prdgxyusw1res-collabaks2/providers/Microsoft.Compute/disks/kubernetes-dynamic-pvc-bd431821-2dfe-4d8c-bd6d-2bc1fa7367e1\\\") on node \\\"aks-kubesys-14323105-vmss0000nt\\\" : Retriable: false, RetryAfter: 0s, HTTPStatusCode: 400, RawError: Retriable: false, RetryAfter: 0s, HTTPStatusCode: 400, RawError: {\\r\\n  \\\"error\\\": {\\r\\n    \\\"code\\\": \\\"InvalidParameter\\\",\\r\\n    \\\"message\\\": \\\"The provided instanceId 857 is not an active Virtual Machine Scale Set VM instanceId.\\\",\\r\\n    \\\"target\\\": \\\"instanceIds\\\"\\r\\n  }\\r\\n}\"\n","stream":"stderr","pod":"kube-controller-manager-9877769bf-rd9jj","containerID":"111e49911995816867f05557bdfa762622dd03036c8510ec85b5cc8a2a939db3"}

/kind bug
/assign @feiskyer
/priority important-soon
/sig cloud-provider
/area provider/azure
/triage accepted

Does this PR introduce a user-facing change?

fix detach disk issue on deleting vmss node

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

fix detach disk issue on deleting node

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. area/provider/azure Issues or PRs related to azure provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. triage/accepted Indicates an issue or PR is ready to be actively worked on. labels Aug 25, 2021
@andyzhangx
Copy link
Member Author

/retest

Copy link
Member

@feiskyer feiskyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 26, 2021
@feiskyer
Copy link
Member

@andrewsykim could you help to approve the bug fix?

/assign @andrewsykim

@andyzhangx
Copy link
Member Author

@andrewsykim @cheftako could you approve? thanks.

@cheftako
Copy link
Member

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx, cheftako, feiskyer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@saschagrunert
Copy link
Member

I assume a cherry-pick to release-1.19 is not required, right?

k8s-ci-robot added a commit that referenced this pull request Oct 6, 2021
…104572-upstream-release-1.20

Automated cherry pick of #104572: fix detach disk issue on deleting node
k8s-ci-robot added a commit that referenced this pull request Oct 6, 2021
…104572-upstream-release-1.21

Automated cherry pick of #104572: fix detach disk issue on deleting node
@andyzhangx
Copy link
Member Author

I assume a cherry-pick to release-1.19 is not required, right?

@saschagrunert correct, thanks.

k8s-ci-robot added a commit that referenced this pull request Oct 7, 2021
…104572-upstream-release-1.22

Automated cherry pick of #104572: fix detach disk issue on deleting node
@liggitt liggitt added the kind/regression Categorizes issue or PR as related to a regression from a prior release. label Apr 27, 2022
@liggitt liggitt removed the kind/regression Categorizes issue or PR as related to a regression from a prior release. label Sep 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cloudprovider area/provider/azure Issues or PRs related to azure provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants