New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: ignore the case when updating tags #104593
Conversation
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/assign @cheftako |
/lgtm |
@cheftako could you please take a look again? |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cheftako, feiskyer, nilo19 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass. This bot retests PRs for certain kubernetes repos according to the following rules:
You can:
/retest |
@nilo19 , I see you created backports for 1.20 and 1.21 but backport for 1.22 is missing? Can you please check? |
@ialidzhikov yeah, I need #104705 to be merged and I will continue the cherry pick. |
@nilo19 please open all cherry-pick PR's in parallel if possible, that way we can ensure that they merge (almost) simultaneously. |
…93-upstream-release-1.21 Automated cherry pick of #104593: fix: ignore the case when updating tags
…93-upstream-release-1.20 Automated cherry pick of #104593: fix: ignore the case when updating tags
…93-upstream-release-1.22 Automated cherry pick of #104593: fix: ignore the case when updating tags
What type of PR is this?
/kind bug
What this PR does / why we need it:
The tags on azure are case-insensitive for both keys and values. We need to ignore the case when comparing existing and new tags.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:
/triage accepted
/sig cloud-provider
/area provider/azure
/priority critical-urgent
cc @feiskyer