Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ignore the case when updating tags #104593

Merged
merged 1 commit into from Aug 31, 2021

Conversation

nilo19
Copy link
Member

@nilo19 nilo19 commented Aug 26, 2021

What type of PR is this?

/kind bug

What this PR does / why we need it:

The tags on azure are case-insensitive for both keys and values. We need to ignore the case when comparing existing and new tags.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

fix: ignore the case when updating Azure tags

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


/triage accepted
/sig cloud-provider
/area provider/azure
/priority critical-urgent
cc @feiskyer

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/provider/azure Issues or PRs related to azure provider priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. area/cloudprovider labels Aug 26, 2021
@nilo19
Copy link
Member Author

nilo19 commented Aug 26, 2021

/retest

Copy link
Member

@feiskyer feiskyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 26, 2021
@nilo19
Copy link
Member Author

nilo19 commented Aug 26, 2021

/assign @cheftako

@cheftako
Copy link
Member

/lgtm
Can we specify in the release notes that this is an Azure user facing change?

@nilo19
Copy link
Member Author

nilo19 commented Aug 30, 2021

@cheftako could you please take a look again?

@cheftako
Copy link
Member

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cheftako, feiskyer, nilo19

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 31, 2021
@k8s-triage-robot
Copy link

The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass.

This bot retests PRs for certain kubernetes repos according to the following rules:

  • The PR does have any do-not-merge/* labels
  • The PR does not have the needs-ok-to-test label
  • The PR is mergeable (does not have a needs-rebase label)
  • The PR is approved (has cncf-cla: yes, lgtm, approved labels)
  • The PR is failing tests required for merge

You can:

/retest

@ialidzhikov
Copy link
Contributor

@nilo19 , I see you created backports for 1.20 and 1.21 but backport for 1.22 is missing? Can you please check?

@nilo19 nilo19 deleted the fix/tag-case branch September 2, 2021 08:09
@nilo19
Copy link
Member Author

nilo19 commented Sep 2, 2021

@ialidzhikov yeah, I need #104705 to be merged and I will continue the cherry pick.

@saschagrunert
Copy link
Member

@nilo19 please open all cherry-pick PR's in parallel if possible, that way we can ensure that they merge (almost) simultaneously.

k8s-ci-robot added a commit that referenced this pull request Oct 14, 2021
…93-upstream-release-1.21

Automated cherry pick of #104593: fix: ignore the case when updating tags
k8s-ci-robot added a commit that referenced this pull request Oct 14, 2021
…93-upstream-release-1.20

Automated cherry pick of #104593: fix: ignore the case when updating tags
k8s-ci-robot added a commit that referenced this pull request Jan 13, 2022
…93-upstream-release-1.22

Automated cherry pick of #104593: fix: ignore the case when updating tags
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cloudprovider area/provider/azure Issues or PRs related to azure provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants