Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Request: Add ehashman as a sig-node API review shadow #104848

Merged
merged 1 commit into from
Sep 9, 2021
Merged

Request: Add ehashman as a sig-node API review shadow #104848

merged 1 commit into from
Sep 9, 2021

Conversation

ehashman
Copy link
Member

@ehashman ehashman commented Sep 8, 2021

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

I would like to be an API review shadow for the 1.23 cycle. SIG Node identified some bandwidth problems in 1.22 on API reviews so this is potentially one way I can help.

Adding myself as a reviewer per instructions in the previous SIG Arch meeting.

/sig architecture node
/assign @derekwaynecarr @liggitt

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added the release-note-none Denotes a PR that doesn't merit a release note. label Sep 8, 2021
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/node Categorizes an issue or PR as relevant to SIG Node. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Sep 8, 2021
@k8s-ci-robot
Copy link
Contributor

@ehashman: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-priority Indicates a PR lacks a `priority/foo` label and requires one. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 8, 2021
@derekwaynecarr
Copy link
Member

derekwaynecarr commented Sep 8, 2021 •
edited

+1

/lgtm

liggitt
liggitt reviewed Sep 8, 2021
View reviewed changes
Copy link
Member

@liggitt liggitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

OWNERS_ALIASES
@@ -487,6 +487,7 @@ aliases:
- derekwaynecarr
- tallclair
- yujuhong
- ehashman
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 to increasing active API reviewers here

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ehashman, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 8, 2021
@liggitt
Copy link
Member

liggitt commented Sep 8, 2021

@derekwaynecarr @dchen1107 as a follow-up, if some of the other folks in this alias aren't actively participating in node API reviews any more, it would be helpful to keep this list trimmed to help focus assignments/involvement to maximize knowledge transfer

@liggitt
Copy link
Member

liggitt commented Sep 8, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 8, 2021
@ehashman
Copy link
Member Author

ehashman commented Sep 8, 2021

/retest
flaky UT...

@k8s-ci-robot k8s-ci-robot merged commit 9956551 into kubernetes:master Sep 9, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Sep 9, 2021
@pacoxu pacoxu mentioned this pull request Sep 9, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liggitt liggitt liggitt left review comments

@brendandburns brendandburns Awaiting requested review from brendandburns

@thockin thockin Awaiting requested review from thockin

Assignees

@liggitt liggitt

@derekwaynecarr derekwaynecarr

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/node Categorizes an issue or PR as relevant to SIG Node. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.23
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ehashman @k8s-ci-robot @derekwaynecarr @liggitt