-
Notifications
You must be signed in to change notification settings - Fork 39.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update github.com/pkg/errors in test/conformance/image/go-runner/ with native go pkg #104948
update github.com/pkg/errors in test/conformance/image/go-runner/ with native go pkg #104948
Conversation
@ishangupta-ds: This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Hi @ishangupta-ds. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
Just be sure to squash down to one commit. |
278d723
to
2dda4c8
Compare
/lgtm |
The latest failure was a problem with kind/infra in some way; tests passed:
The other failure was a time out which is just probably a flake. I'd expect this to be fine. /retest |
It says, |
1235ecc
to
fa2dfb0
Compare
…o-runner/ directory Signed-off-by: ishangupta-ds <ishangupta.ds@gmail.com> formatted using gofmt script Signed-off-by: ishangupta-ds <ishangupta.ds@gmail.com> adding nil check for error Signed-off-by: ishangupta-ds <ishangupta.ds@gmail.com> adding nil check for errors Signed-off-by: ishangupta-ds <ishangupta.ds@gmail.com> formatted Signed-off-by: ishangupta-ds <ishangupta.ds@gmail.com>
5cb23e5
to
c6b82bd
Compare
/assign @timothysc |
/lgtm |
quick question, why exactly would we change this? I see this as a partial code shuffle back with little gain. We chose to use errors.Wrap on purpose. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dims, ishangupta-ds, johnSchnake The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: ishangupta-ds ishangupta.ds@gmail.com
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
removing usage of github.com/pkg/errors from test/conformance/image/go-runner/ directory
Which issue(s) this PR fixes:
Fixes part of #103043
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: