Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ineligible_endpoint.yaml to include RBAC #104978

Merged
merged 1 commit into from
Sep 13, 2021
Merged

Update ineligible_endpoint.yaml to include RBAC #104978

merged 1 commit into from
Sep 13, 2021

Conversation

riaankleinhans
Copy link
Contributor

@riaankleinhans riaankleinhans commented Sep 13, 2021 •
edited

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
This PR adds the RBAC endpoints to the Ineligible_endpoint.yaml because the endpoints are optional features

  • createRbacAuthorizationV1ClusterRole
  • createRbacAuthorizationV1ClusterRoleBinding
  • createRbacAuthorizationV1NamespacedRoleBinding
  • deleteRbacAuthorizationV1ClusterRole
  • deleteRbacAuthorizationV1ClusterRoleBinding
  • deleteRbacAuthorizationV1NamespacedRoleBinding
  • getRbacAuthorizationV1APIResources
  • getRbacAuthorizationAPIGroup
  • createRbacAuthorizationV1NamespacedRole
  • deleteRbacAuthorizationV1CollectionClusterRole
  • deleteRbacAuthorizationV1CollectionClusterRoleBinding
  • deleteRbacAuthorizationV1CollectionNamespacedRole
  • deleteRbacAuthorizationV1CollectionNamespacedRoleBinding
  • deleteRbacAuthorizationV1NamespacedRole
  • listRbacAuthorizationV1ClusterRole
  • listRbacAuthorizationV1ClusterRoleBinding
  • listRbacAuthorizationV1NamespacedRole
  • listRbacAuthorizationV1NamespacedRoleBinding
  • listRbacAuthorizationV1RoleBindingForAllNamespaces
  • listRbacAuthorizationV1RoleForAllNamespaces
  • patchRbacAuthorizationV1ClusterRole
  • patchRbacAuthorizationV1ClusterRoleBinding
  • patchRbacAuthorizationV1NamespacedRole
  • patchRbacAuthorizationV1NamespacedRoleBinding
  • readRbacAuthorizationV1ClusterRole
  • readRbacAuthorizationV1ClusterRoleBinding
  • readRbacAuthorizationV1NamespacedRole
  • readRbacAuthorizationV1NamespacedRoleBinding
  • replaceRbacAuthorizationV1ClusterRole
  • replaceRbacAuthorizationV1ClusterRoleBinding
  • replaceRbacAuthorizationV1NamespacedRole
  • replaceRbacAuthorizationV1NamespacedRoleBinding

Special notes for your reviewer:
As of 1.22 APISnoop Ineligible endpoints are pulled from the community owned inelegible_endpoint.yaml file

Does this PR introduce a user-facing change?:

NONE

Release note:

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

NONE

/sig architecture
/area conformance

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. area/conformance Issues or PRs related to kubernetes conformance tests cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Sep 13, 2021
@riaankleinhans
Copy link
Contributor Author

/triage accepted

/assign @johnbelamaric @smarterclayton @liggitt
/cc @hh

@k8s-ci-robot k8s-ci-robot added the triage/accepted Indicates an issue or PR is ready to be actively worked on. label Sep 13, 2021
@k8s-ci-robot k8s-ci-robot removed the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Sep 13, 2021
@hh
Copy link
Member

hh commented Sep 13, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 13, 2021
@johnbelamaric
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johnbelamaric, Riaankl

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 13, 2021
@k8s-ci-robot k8s-ci-robot merged commit 5cbe265 into kubernetes:master Sep 13, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Sep 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnbelamaric johnbelamaric Awaiting requested review from johnbelamaric

@spiffxp spiffxp Awaiting requested review from spiffxp

@hh hh Awaiting requested review from hh

Assignees

@hh hh

@liggitt liggitt

@smarterclayton smarterclayton

@johnbelamaric johnbelamaric

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/conformance Issues or PRs related to kubernetes conformance tests cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.23
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@riaankleinhans @hh @johnbelamaric @k8s-ci-robot @liggitt @smarterclayton