Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix workqueue memory leak #104991

Merged
merged 1 commit into from Sep 15, 2021
Merged

Fix workqueue memory leak #104991

merged 1 commit into from Sep 15, 2021

Conversation

hzxuzhonghu
Copy link
Member

What type of PR is this?

/kind bug

What this PR does / why we need it:

resize the slice may not influence the underlying array's capacity, so it still references the element that dequeued

FYI: https://stackoverflow.com/questions/55045402/memory-leak-in-golang-slice

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Sep 14, 2021
@k8s-ci-robot k8s-ci-robot added sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Sep 14, 2021
@hzxuzhonghu
Copy link
Member Author

/assign @sttts

@fedebongio
Copy link
Contributor

/assign @yliaog
/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Sep 14, 2021
@liggitt liggitt mentioned this pull request Sep 15, 2021
Merged
@yliaog
Copy link
Contributor

yliaog commented Sep 15, 2021

looks to be the same fix as #105031, we can merge this for the fix, and get the tests from #105031

@yliaog
Copy link
Contributor

yliaog commented Sep 15, 2021

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 15, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hzxuzhonghu, yliaog

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 15, 2021
@k8s-ci-robot k8s-ci-robot merged commit 4c014e5 into kubernetes:master Sep 15, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Sep 15, 2021
@hzxuzhonghu hzxuzhonghu deleted the mem-leak branch September 15, 2021 06:12
@ialidzhikov
Copy link
Contributor

Hello 👋

Does this PR deserve a backport?

@liggitt
Copy link
Member

liggitt commented Sep 15, 2021

yeah, it should be backported

@ialidzhikov
Copy link
Contributor

ialidzhikov commented Sep 29, 2021 •
edited

@hzxuzhonghu @howardjohn can you please take care to backport this PR (+ the one that adds the corresponding test) to all affected versions? Thank you in advance.

@hzxuzhonghu
Copy link
Member Author

/cherry-pick release-1.22

@ialidzhikov
Copy link
Contributor

/cherry-pick release-1.22

@hzxuzhonghu @howardjohn I am not aware of such command that does the backport automatically. Can you take care to create the cherry-picks?
You can use https://github.com/kubernetes/community/blob/master/contributors/devel/sig-release/cherry-picks.md#initiate-a-cherry-pick.

@ialidzhikov
Copy link
Contributor

ping @hzxuzhonghu @howardjohn

@hzxuzhonghu
Copy link
Member Author

@ialidzhikov sorry, will do it today

@ialidzhikov ialidzhikov mentioned this pull request Nov 12, 2021
Closed
This was referenced Nov 22, 2021
Merged
Merged
Merged
k8s-ci-robot added a commit that referenced this pull request Jan 15, 2022
@k8s-ci-robot
Merge pull request #106583 from hzxuzhonghu/automated-cherry-pick-of-…
9d7f909 
…#104991-#105031-origin-release-1.21

Automated cherry pick of #104991: Fix workqueue memory leak
#105031: workqueue: fix leak in queue preventing objects from being
k8s-ci-robot added a commit that referenced this pull request Jan 15, 2022
@k8s-ci-robot
Merge pull request #106582 from hzxuzhonghu/automated-cherry-pick-of-…
dcb59ac 
…#104991-#105031-origin-release-1.22

Automated cherry pick of #104991: Fix workqueue memory leak
#105031: workqueue: fix leak in queue preventing objects from being
k8s-ci-robot added a commit that referenced this pull request Jan 15, 2022
@k8s-ci-robot
Merge pull request #106585 from hzxuzhonghu/automated-cherry-pick-of-…
97bc208 
…#104991-#105031-origin-release-1.20

Automated cherry pick of #104991: Fix workqueue memory leak
#105031: workqueue: fix leak in queue preventing objects from being
This was referenced Jan 17, 2022
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@niulechuan niulechuan niulechuan left review comments

@sttts sttts Awaiting requested review from sttts

@yliaog yliaog Awaiting requested review from yliaog

Assignees

@sttts sttts

@yliaog yliaog

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.23
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@hzxuzhonghu @fedebongio @yliaog @k8s-ci-robot @ialidzhikov @liggitt @niulechuan @sttts