component-base: avoid accumulating default labels #105541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The intention in kubernetes@ecb3813 was to use the component-base/OWNERS labels only as fallback when the OWNERS files in the sub-directories don't set labels. This should never have been necessary because all of those sub-directories have reasonable labels configured. But in practice, the labels were also added to PRs that only touched files in sub-directory because OWNERS files are inherited, which created noise in various sigs that shouldn't have been tagged for those PRs.
k8s-ci-robot
added
release-note-none
pohly
referenced
this pull request
Oct 7, 2021
Also update OWNERS in subdirs based on best-guess picks of appropriate OWNERS. We can update as necessary in future iterations but this'll help reduce initial noise for SIG-Arch.
k8s-ci-robot
added
do-not-merge/needs-sig
k8s-ci-robot
added
sig/api-machinery
|
/remove-sig api-machinery |
k8s-ci-robot
removed
the
sig/api-machinery
|
/lgtm |
k8s-ci-robot
added
the
lgtm
mtaufen
added
priority/important-longterm
k8s-ci-robot
removed
the
needs-priority
|
/triage accepted |
k8s-ci-robot
added
triage/accepted
|
/assign @derekwaynecarr |
|
Context in #105414 (comment). We wanted to use these labels as a fallback but that doesn't seem to be the behavior. Since subdirs are already labeled, I'm okay deleting these to reduce noise. |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
Looks like @derekwaynecarr is busy or missed this one. @dims : can you approve? /assign @dims |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dims, pohly The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
The intention in
ecb3813
was to use the component-base/OWNERS labels only as fallback when the OWNERS
files in the sub-directories don't set labels. This should never have been
necessary because all of those sub-directories have reasonable labels
configured.
But in practice, the labels were also added to PRs that only touched files in
sub-directory because OWNERS files are inherited, which created noise in
various sigs that shouldn't have been tagged for those PRs.
Does this PR introduce a user-facing change?