Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove scheduler NodeLabel plugin #105906

Merged
merged 1 commit into from
Oct 27, 2021
Merged

remove scheduler NodeLabel plugin #105906

merged 1 commit into from
Oct 27, 2021

Conversation

kerthcet
Copy link
Member

@kerthcet kerthcet commented Oct 26, 2021 •
edited

Signed-off-by: kerthcet kerthcet@gmail.com

What type of PR is this?

/kind feature

What this PR does / why we need it:

NodeLabel is deprecated now, it was used to be configurable via policy config; now that policy config is removed, so we should also remove the plugin.

Which issue(s) this PR fixes:

Part of: ##105883

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Oct 26, 2021
@k8s-ci-robot
Copy link
Contributor

@kerthcet: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Oct 26, 2021
@kerthcet
Copy link
Member Author

/sig scheduling

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Oct 26, 2021
@kerthcet
Copy link
Member Author

/retest

@kerthcet kerthcet force-pushed the feature/remove-scheduler-plugin-node-label branch from c69369c to eefa4f2 Compare October 26, 2021 11:12
@k8s-triage-robot
Copy link

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

@kerthcet kerthcet force-pushed the feature/remove-scheduler-plugin-node-label branch from eefa4f2 to ef4564a Compare October 26, 2021 12:34
@kerthcet
Copy link
Member Author

@ahg-g PTAL

@kerthcet kerthcet force-pushed the feature/remove-scheduler-plugin-node-label branch from ef4564a to fb07707 Compare October 27, 2021 00:00
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 27, 2021
@kerthcet kerthcet force-pushed the feature/remove-scheduler-plugin-node-label branch from fb07707 to 78b1c80 Compare October 27, 2021 00:19
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Oct 27, 2021
@kerthcet
Copy link
Member Author

rebased the code to solve the conflicts.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 27, 2021
@kerthcet kerthcet force-pushed the feature/remove-scheduler-plugin-node-label branch from 78b1c80 to 8e1b6b4 Compare October 27, 2021 01:50
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 27, 2021
@kerthcet
remove scheduler NodeLabel plugin
2c5b553 
Signed-off-by: kerthcet <kerthcet@gmail.com>
@kerthcet kerthcet force-pushed the feature/remove-scheduler-plugin-node-label branch from 8e1b6b4 to 2c5b553 Compare October 27, 2021 02:07
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 27, 2021
@kerthcet
Copy link
Member Author

/retest

@kerthcet
Copy link
Member Author

solved the code conflicts.

@ahg-g
Copy link
Member

ahg-g commented Oct 27, 2021

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 27, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahg-g, kerthcet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 27, 2021
@k8s-ci-robot k8s-ci-robot merged commit a0a79e3 into kubernetes:master Oct 27, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Oct 27, 2021
@kerthcet kerthcet deleted the feature/remove-scheduler-plugin-node-label branch October 27, 2021 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahg-g ahg-g ahg-g left review comments

@chendave chendave Awaiting requested review from chendave

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

Assignees

@ahg-g ahg-g

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
v1.23
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kerthcet @k8s-ci-robot @k8s-triage-robot @ahg-g