PodSecurity: return namespace validation errors in standard field.ErrorList format #105959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note-none
k8s-ci-robot
added
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: liggitt The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
tallclair
reviewed
Oct 28, 2021
| var labelsPath = field.NewPath("metadata", "labels") | ||
|
|
||
| // appendErr is a helper function to collect label-specific errors. | ||
| func appendErr(errs field.ErrorList, err error, label, value string) field.ErrorList { |
There was a problem hiding this comment.
nit
Suggested change
| func appendErr(errs field.ErrorList, err error, label, value string) field.ErrorList { | |
| func appendLabelValidationErr(errs field.ErrorList, err error, label, value string) field.ErrorList { |
There was a problem hiding this comment.
sorry, didn't make it here before merge
k8s-ci-robot
added
the
lgtm
|
/triage accepted |
k8s-ci-robot
added
triage/accepted
5 tasks
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
/kind feature
Which issue(s) this PR fixes:
Fixes the returned error for namespace label validation so that kubectl displays the error details (it only displays detail messages for "invalid request" errors)
Does this PR introduce a user-facing change?
/assign @tallclair
/sig auth
/milestone v1.23