Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding e2e tests to validate volume mounts in HostProcessContainers on Windows #105996

Merged
merged 1 commit into from
Nov 4, 2021
Merged

Adding e2e tests to validate volume mounts in HostProcessContainers on Windows #105996

merged 1 commit into from
Nov 4, 2021

Conversation

marosset
Copy link
Contributor

Signed-off-by: Mark Rossetti marosset@microsoft.com

What type of PR is this?

/kind feature

What this PR does / why we need it:

This PR adds e2e tests to validate volume mounts in HostProcessContainers on Windows

Which issue(s) this PR fixes:

Part of kubernetes/enhancements#1981

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

[KEP]: https://github.com/kubernetes/enhancements/tree/master/keps/sig-windows/1981-windows-privileged-container-support

/sig windows
/area test
/milestone v1.23
/assign @jsturtevant

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/feature Categorizes issue or PR as related to a new feature. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. sig/windows Categorizes an issue or PR as relevant to SIG Windows. labels Oct 29, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Oct 29, 2021
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/test needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Oct 29, 2021
@k8s-ci-robot
Copy link
Contributor

@marosset: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Oct 29, 2021
@marosset marosset mentioned this pull request Oct 29, 2021
Closed
35 tasks
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Oct 29, 2021
@marosset
Copy link
Contributor Author

/priority important-soon

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Oct 29, 2021
jsturtevant
jsturtevant reviewed Oct 29, 2021
View reviewed changes
test/e2e/windows/host_process.go Outdated Show resolved Hide resolved
test/e2e/windows/host_process.go Outdated Show resolved Hide resolved
test/e2e/windows/host_process.go Outdated Show resolved Hide resolved
test/e2e/windows/host_process.go Outdated
podName := "host-process-volume-mounts"
username := "NT AUTHORITY\\SYSTEM"
hostPathDirectoryOrCreate := v1.HostPathDirectoryOrCreate
pod := &v1.Pod{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it will be easier to read the flow of the test if this was in a separate function as well.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I moved the pod defintion to a new function - makeTestPodWithVolumeMounts()

test/e2e/windows/host_process.go Outdated

trueVar := true
podName := "host-process-volume-mounts"
username := "NT AUTHORITY\\SYSTEM"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does the user matter here? do we want to test any others?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it matter. What username do you suggest?

@marosset marosset force-pushed the host-process-volume-mount-e2e branch from c85fbbc to edc6896 Compare October 29, 2021 21:03
@k8s-ci-robot k8s-ci-robot added sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. sig/storage Categorizes an issue or PR as relevant to SIG Storage. and removed approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 29, 2021
@marosset marosset force-pushed the host-process-volume-mount-e2e branch from edc6896 to 06e8031 Compare October 29, 2021 21:09
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: marosset

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 29, 2021
@marosset
Copy link
Contributor Author

@jsturtevant i've made most of the requested updates PTAL
Thanks!

jsturtevant
jsturtevant reviewed Oct 29, 2021
View reviewed changes
test/e2e/windows/host_process.go

logs, err := e2epod.GetPodLogs(f.ClientSet, ns.Name, podAndContainerName, podAndContainerName)
framework.ExpectNoError(err, "Error getting pod logs")
framework.Logf("Container logs: %s", logs)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was thinking this should only be done in the case of failure so it would help understand why this test might have failed from reading the test logs. I don't think the logs would be verbose in the success state so It might be fine here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea, right now i'll just output SUCCESS which shouldn't bloat the logs too much.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 3, 2021
@marosset
Adding e2e tests to validate volume mounts in HostProcessContainers o…
5dffdfc 
…n Windows

Signed-off-by: Mark Rossetti <marosset@microsoft.com>
@marosset marosset force-pushed the host-process-volume-mount-e2e branch from ccc0679 to 5dffdfc Compare November 3, 2021 21:02
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 3, 2021
@jsturtevant
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 3, 2021
@k8s-ci-robot k8s-ci-robot merged commit 662ea77 into kubernetes:master Nov 4, 2021
@marosset marosset deleted the host-process-volume-mount-e2e branch October 31, 2022 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsturtevant jsturtevant jsturtevant left review comments

@adelina-t adelina-t Awaiting requested review from adelina-t

@chewong chewong Awaiting requested review from chewong

Assignees

@jsturtevant jsturtevant

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. sig/storage Categorizes an issue or PR as relevant to SIG Storage. sig/testing Categorizes an issue or PR as relevant to SIG Testing. sig/windows Categorizes an issue or PR as relevant to SIG Windows. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.23
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@marosset @k8s-ci-robot @jsturtevant