Fixes for graceful node shutdown test #106108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
do-not-merge/work-in-progress
|
/test pull-kubernetes-node-kubelet-serial |
k8s-ci-robot
added
area/test
sig/node
SergeyKanzhelev
moved this from Triage
to PRs Waiting on Author
in SIG Node CI/Test Board
|
/priority important-soon |
k8s-ci-robot
added
priority/important-soon
|
@bobbypage: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
* Bump the pod status and node status update timeouts to avoid flakes * Add a small delay after dbus restart to ensure dbus has enough time to restart to startup prior to sending shutdown signal * Change check of pod being terminated by graceful shutdown. Previously, the pod phase was checked to see if it was `Failed` and the pod reason string matched. This logic needs to change after 1.22 graceful node shutdown change introduced in PR kubernetes#102344 which changed behavior to no longer put the pods into a failed phase. Instead, the test now checks that containers are not ready, and the pod status message and reason are set appropriately. Signed-off-by: David Porter <david@porter.me>
bobbypage
force-pushed
the
graceful-shutdown-test-fixes
branch
from
7206a61
to
ddd0d8a
Compare
bobbypage
changed the title
k8s-ci-robot
added
release-note-none
k8s-ci-robot
removed
the
do-not-merge/release-note-label-needed
|
This is ready to review. With these changes in the above serial run, graceful node shutdown test passed. |
|
/cc @wzshiming @smarterclayton @mrunalp |
|
/kind failing-test |
k8s-ci-robot
added
kind/failing-test
k8s-ci-robot
added
the
lgtm
SergeyKanzhelev
approved these changes
Nov 4, 2021
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bobbypage, SergeyKanzhelev, wzshiming The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: David Porter david@porter.me
What type of PR is this?
/kind failing-test
What this PR does / why we need it:
restart prior to sending shutdown signal
the pod phase was checked to see if it was
Failedand the pod reasonstring matched. This logic needs to change after 1.22 graceful node
shutdown change introduced in PR Prevent Kubelet from incorrectly interpreting "not yet started" pods as "ready to terminate pods" by unifying responsibility for pod lifecycle into pod worker #102344 which changed behavior to no
longer put the pods into a failed phase. Instead, the test now checks
that containers are not ready, and the pod status message and reason
are set appropriately.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: