E2E podresources: fix test checking esclusive cpus allocation #106116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note-none
|
/sig node |
k8s-ci-robot
added
sig/node
k8s-ci-robot
added
area/test
sig/testing
ffromani
changed the title
|
/hold |
k8s-ci-robot
added
the
do-not-merge/hold
ffromani
force-pushed
the
e2e-podresources-fix
branch
from
7cfb055
to
6102b7e
Compare
SergeyKanzhelev
moved this from Triage
to PRs - Needs Reviewer
in SIG Node CI/Test Board
|
/assign @cynepco3hahue |
k8s-ci-robot
added
triage/accepted
k8s-ci-robot
added
the
lgtm
ffromani
force-pushed
the
e2e-podresources-fix
branch
from
6102b7e
to
94e6fea
Compare
k8s-ci-robot
removed
the
lgtm
@fromanirh do you still need this hold? |
SergeyKanzhelev
approved these changes
Nov 8, 2021
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fromanirh, SergeyKanzhelev The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
yes, but I plan to lift it soon as the last internal verification is in progress (pending BM availability) |
|
BM tests revealed an additional issue with kubelet restart. Investigating. Will keep updating. |
|
ok, restarting the kubelet in the e2e tests seems to be broken. I'll investigate. |
|
Can be related to recent PRs related to DynamicKubeletConfguration removal. I will re-check the code. |
the intent is to make the code more readable, no intended changes in behaviour. Now it should be a bit more explicit why the code is checking some values. Signed-off-by: Francesco Romani <fromani@redhat.com>
Since commit 42dd01a the cpuRequest is in millicores, hence we need to properly check translating to exclusive cpus when verifying the resource allocation. Signed-off-by: Francesco Romani <fromani@redhat.com>
ffromani
force-pushed
the
e2e-podresources-fix
branch
from
94e6fea
to
4b46c3a
Compare
we need to make sure the system state is completely cleaned up again, to avoid to mess up with the shared node state, before we transition from one test to another. Signed-off-by: Francesco Romani <fromani@redhat.com>
ffromani
force-pushed
the
e2e-podresources-fix
branch
3 times, most recently
from
b850f44
to
a1c10da
Compare
Let's wait for the local node (aka the kubelet) to be ready before to query podresources again, to avoid false negatives. Co-authored-by: Artyom Lukianov <alukiano@redhat.com> Signed-off-by: Francesco Romani <fromani@redhat.com>
ffromani
force-pushed
the
e2e-podresources-fix
branch
from
a1c10da
to
bf9bab5
Compare
|
Our BM tests is green again; we managed to provide a couple extra fixes. Kudos to @cynepco3hahue for helping here! |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
/kind failing-test
What this PR does / why we need it:
Since commit 42dd01a the cpuRequest is in millicores, hence we need to properly check translating to exclusive cpus when verifying the resource allocation.
Which issue(s) this PR fixes:
Fixes N/A
Special notes for your reviewer:
This issue is not evident in our CI because the machines on which CI runs don't have enough cpus to perform exclusive allocations, hence the e2e tests skips. We figured out thanks to RH's internal testing on BM.
Does this PR introduce a user-facing change?