e2e_node: Skip dynamic config tests when the feature is disabled #106263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DKC is being removed and we don't want it to continue flaking the rest of our tests. Lets disable them when dkc is disabled rather than hard failing. This fits more in line with our other E2Es, and reduces the maintenance load in test-infra.
k8s-ci-robot
added
release-note-none
|
/sig node |
k8s-ci-robot
added
sig/node
|
/retest |
3 tasks
|
IIUC the feature should be removed under 1.23, so probably we should just start to delete the relevant code. @SergeyKanzhelev @endocrimes WDT? |
|
@cynepco3hahue we're currently marked for removal in 1.24 (https://github.com/kubernetes/enhancements/blob/master/keps/sig-node/281-dynamic-kubelet-configuration/kep.yaml#L37) - Iirc the deprecation didn't land fast enough for 1.21 to remove in 1.23 |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
ehashman
reviewed
Nov 9, 2021
k8s-ci-robot
added
triage/accepted
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ehashman, endocrimes The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
27 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
DKC is being removed and we don't want it to continue flaking the rest of our tests. To avoid breaking test suites that don't explicitly exclude them, lets also skip them when the feature is disabled. This fits more in line with our other E2Es, and reduces the maintenance load in test-infra.
Does this PR introduce a user-facing change?
/cc @SergeyKanzhelev @cynepco3hahue