Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom formatter for podData and nodeInfo for pkg/scheduler/internal/cache/debugger/dumper.go #106276

Closed
shiva1333 opened this issue Nov 9, 2021 · 8 comments
Assignees
Labels
area/logging kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/feature Categorizes issue or PR as related to a new feature. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. triage/accepted Indicates an issue or PR is ready to be actively worked on. wg/structured-logging Categorizes an issue or PR as relevant to WG Structured Logging.

Comments

@shiva1333
Copy link
Contributor

shiva1333 commented Nov 9, 2021

What would you like to be added?

We need to add a custom formatter like this, test case to see result as part of structured logging

Why is this needed?

Part of structured logging kubernetes/enhancements#1602

@shiva1333 shiva1333 added the kind/feature Categorizes issue or PR as related to a new feature. label Nov 9, 2021
@k8s-ci-robot k8s-ci-robot added needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Nov 9, 2021
@shiva1333
Copy link
Contributor Author

/wg structured-logging
/sig scheduling
/area logging
/priority important-soon
/kind cleanup
/cc @kubernetes/wg-structured-logging-reviews
/cc @pohly

@k8s-ci-robot k8s-ci-robot added wg/structured-logging Categorizes an issue or PR as relevant to WG Structured Logging. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. area/logging priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Nov 9, 2021
@shiva1333
Copy link
Contributor Author

/assign

@shiva1333
Copy link
Contributor Author

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Nov 12, 2021
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 10, 2022
@shiva1333
Copy link
Contributor Author

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 16, 2022
@pohly
Copy link
Contributor

pohly commented Mar 22, 2022

Is this still relevant?

If I remember correctly, we came to the conclusion that formatting as multi-line strings is what developers expect also for JSON output.

@pohly
Copy link
Contributor

pohly commented Mar 22, 2022

#108159 contains the conversion of dumper.go to klog.InfoS without a custom formatter and GitHub will close this issue here once it gets merged. We can reopen if that isn't the right solution.

@liggitt
Copy link
Member

liggitt commented Mar 25, 2022

fixed by #108159

@liggitt liggitt closed this as completed Mar 25, 2022
WG Structured Logging - 1.23 Migration automation moved this from Inbox to Done Mar 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/logging kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/feature Categorizes issue or PR as related to a new feature. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. triage/accepted Indicates an issue or PR is ready to be actively worked on. wg/structured-logging Categorizes an issue or PR as relevant to WG Structured Logging.
Development

No branches or pull requests

5 participants