Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

migrated schedular to structured logging #106305

Merged
merged 1 commit into from
Nov 17, 2021
Merged

migrated schedular to structured logging #106305

merged 1 commit into from
Nov 17, 2021

Conversation

shivanshuraj1333
Copy link
Contributor

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Marking files of pkg/scheduler and cmd/kube-scheduler as migrated to structured logging

Which issue(s) this PR fixes:

Reference #105841

Special notes for your reviewer:

This is not complete migration of pkg/scheduler and cmd/kube-scheduler, the complete migration is blocked by #106262 and #106276
after providing appropriate fixes for the mentioned issues we need to update the packages here as pkg/scheduler/... and cmd/kube-scheduler/...

Excluded files to achieve the complete migration of scheduler are cmd/kube-scheduler/app/options/configfile.go line-96
,and pkg/scheduler/internal/cache/debugger/dumper.go line-49, line-60

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Nov 10, 2021
@shivanshuraj1333
Copy link
Contributor Author

/wg structured-logging
/sig scheduling
/area logging
/priority important-soon
/kind cleanup
/cc @kubernetes/wg-structured-logging-reviews

@k8s-ci-robot k8s-ci-robot added wg/structured-logging Categorizes an issue or PR as relevant to WG Structured Logging. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. area/logging priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Nov 10, 2021
@shivanshuraj1333
Copy link
Contributor Author

/remove-sig scheduling

@k8s-ci-robot k8s-ci-robot removed the sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. label Nov 10, 2021
@shivanshuraj1333
Copy link
Contributor Author

/assign @serathius
/cc @pohly

@shivanshuraj1333
Copy link
Contributor Author

/retest

@serathius
Copy link
Contributor

Got logcheck: -: named files must be .go files: /home/prow/go/src/k8s.io/kubernetes/cmd/kube-proxy/... not sure what's the cause and how it can be broken on master.

serathius
serathius reviewed Nov 11, 2021
View reviewed changes
hack/.structured_logging Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 12, 2021
@shivanshuraj1333
Copy link
Contributor Author

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Nov 12, 2021
pohly
pohly approved these changes Nov 12, 2021
View reviewed changes
Copy link
Contributor

@pohly pohly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/retest

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 12, 2021
@serathius
Copy link
Contributor

/lgtm
/assign @deads2k

@serathius serathius mentioned this pull request Nov 17, 2021
Closed
@serathius
Copy link
Contributor

/milestone v1.23
This PR blocks #105841

@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Nov 17, 2021
@shivanshuraj1333
Copy link
Contributor Author

pinging @dims for approval

@dims
Copy link
Member

dims commented Nov 17, 2021

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, pohly, shivanshu1333

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 17, 2021
@k8s-ci-robot k8s-ci-robot merged commit 557b5fe into kubernetes:master Nov 17, 2021
WG Structured Logging - 1.23 Migration automation moved this from Waiting on Reviewer to Done Nov 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@serathius serathius serathius left review comments

@pohly pohly pohly approved these changes

@sttts sttts Awaiting requested review from sttts

@vishh vishh Awaiting requested review from vishh

Assignees

@pohly pohly

@serathius serathius

@deads2k deads2k

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/logging cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on. wg/structured-logging Categorizes an issue or PR as relevant to WG Structured Logging.
Projects
WG Structured Logging - 1.23 Migration
Done
Milestone
v1.23
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@shivanshuraj1333 @serathius @dims @k8s-ci-robot @pohly @deads2k