New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cherry pick #106045 to 1.20: Fix concurrent map writes error in kube-apiserver #106336
Cherry pick #106045 to 1.20: Fix concurrent map writes error in kube-apiserver #106336
Conversation
@chenlinx17: This cherry pick PR is for a release branch and has not yet been approved by Release Managers. To merge this cherry pick, it must first be approved ( AFTER it has been approved by code owners, please ping the kubernetes/release-managers team in a comment to request a cherry pick review. (For details on the patch release process and schedule, see the Patch Releases page.) Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Hi @chenlinx17. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
/lgtm |
/triage accepted |
/priority important-soon |
/approve Checked again master PR. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chenlinx17, dims, sttts The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Thanks! |
/test pull-kubernetes-e2e-gce-ubuntu-containerd |
The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass. This bot retests PRs for certain kubernetes repos according to the following rules:
You can:
/retest |
What type of PR is this?
/kind bug
What this PR does / why we need it:
this PR #106045 adds a sync.mutex in auditHandler to protect map audit.Event.Annotations from concurrent writes
Which issue(s) this PR fixes:
Fixes a concurrent map writes bug when recording audit event in the delete-collection scenario
Special notes for your reviewer:
this bug trigger condition:
1、enabled audit log for kube-apiserver
2、enabled multi-goroutine for delete collection (--delete-collection-workers > 1)
Does this PR introduce a user-facing change?