Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip OnRootMismatch tests if the CSI driver supports VOLUME_MOUNT_GROUP. #106395

Merged
merged 1 commit into from
Nov 15, 2021
Merged

Skip OnRootMismatch tests if the CSI driver supports VOLUME_MOUNT_GROUP. #106395

merged 1 commit into from
Nov 15, 2021

Conversation

verult
Copy link
Contributor

@verult verult commented Nov 13, 2021 •
edited

What type of PR is this?

/kind feature

What this PR does / why we need it:

CSI drivers that support volume mount group are not required to have the capability to respect the fsgroup change policy of OnRootMismatch, i.e. recursively apply fsgroup only when the root directory has a different fsgroup. This PR skips those test and prevents a regression when the DelegateFSGroupToCSIDriver feature gate is on by default in beta.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

None

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

- [KEP]: https://github.com/kubernetes/enhancements/issues/2317

/assign @gnufied @saikat-royc
/sig storage

@k8s-ci-robot k8s-ci-robot added the release-note-none Denotes a PR that doesn't merit a release note. label Nov 13, 2021
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/test sig/storage Categorizes an issue or PR as relevant to SIG Storage. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Nov 13, 2021
@verult
Copy link
Contributor Author

verult commented Nov 13, 2021

/kind feature
/sig storage
/triage accepted
/priority important-soon

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Nov 13, 2021
@verult
Copy link
Contributor Author

verult commented Nov 13, 2021

/milestone 1.23

@k8s-ci-robot
Copy link
Contributor

@verult: You must be a member of the kubernetes/milestone-maintainers GitHub team to set the milestone. If you believe you should be able to issue the /milestone command, please contact your and have them propose you as an additional delegate for this responsibility.

In response to this:

/milestone 1.23

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@verult
Copy link
Contributor Author

verult commented Nov 14, 2021

/test pull-kubernetes-integration

@gnufied
Copy link
Member

gnufied commented Nov 14, 2021

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 14, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gnufied, verult

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 14, 2021
@k8s-triage-robot
Copy link

The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass.

This bot retests PRs for certain kubernetes repos according to the following rules:

  • The PR does have any do-not-merge/* labels
  • The PR does not have the needs-ok-to-test label
  • The PR is mergeable (does not have a needs-rebase label)
  • The PR is approved (has cncf-cla: yes, lgtm, approved labels)
  • The PR is failing tests required for merge

You can:

/retest

@k8s-ci-robot k8s-ci-robot merged commit 991bb65 into kubernetes:master Nov 15, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Nov 15, 2021
@verult verult mentioned this pull request Nov 15, 2021
Merged
msau42
msau42 reviewed Nov 15, 2021
View reviewed changes
test/e2e/storage/testsuites/fsgroupchangepolicy.go
policy := v1.PodFSGroupChangePolicy(test.podfsGroupChangePolicy)

if dInfo.Capabilities[storageframework.CapVolumeMountGroup] &&
utilfeature.DefaultFeatureGate.Enabled(features.DelegateFSGroupToCSIDriver) &&
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not think this feature gate check works. I don't think we have an api to detect which feature gates are enabled on a cluster. I think we need to leave it up to the provider to appropriately set the driver capabilities.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

uh yeah. I thought we were solely relying on CapVolumeMountGroup, didn't notice feature gate check.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, in the (common?) case of e2e binary being the same minor version as the cluster this might help. But if a lower version test binary runs against a higher version cluster, this test will not skip even if the driver has the right capability. So I'll remove this check.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#106435

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even if the e2e.test and the Kubernetes version match exactly you cannot use utilfeature in the client to check for features in the server.

@verult verult mentioned this pull request Nov 15, 2021
Merged
@verult
Copy link
Contributor Author

verult commented Nov 24, 2021

cc @andyzhangx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gnufied gnufied gnufied left review comments

@msau42 msau42 msau42 left review comments

@mattcary mattcary Awaiting requested review from mattcary

@pohly pohly Awaiting requested review from pohly

Assignees

@gnufied gnufied

@saikat-royc saikat-royc

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/storage Categorizes an issue or PR as relevant to SIG Storage. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.23
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@verult @k8s-ci-robot @gnufied @k8s-triage-robot @pohly @msau42 @saikat-royc