Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

De-flake ephemeral containers e2e test #106425

Merged
merged 1 commit into from
Nov 15, 2021
Merged

De-flake ephemeral containers e2e test #106425

merged 1 commit into from
Nov 15, 2021

Conversation

verb
Copy link
Contributor

@verb verb commented Nov 15, 2021

What type of PR is this?

/kind bug
/kind flake

What this PR does / why we need it:

The flaking test always fails with the polo test path. The test waits for the container to be running, but the test command sleeps for 2 seconds before writing output, creating a race. Presumably this started failing because the previous kubectl implementation takes more than 2 seconds to run.

Which issue(s) this PR fixes:

Fixes #106341

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@verb
De-flake ephemeral containers e2e test
28bd71c 
The test waits for the container to be running, but the test command
sleeps for 2 seconds before writing output, creating a race.
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. kind/flake Categorizes issue or PR as related to a flaky test. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Nov 15, 2021
@verb
Copy link
Contributor Author

verb commented Nov 15, 2021

/sig node
/triage accepted
/priority important-soon

@k8s-ci-robot k8s-ci-robot added sig/node Categorizes an issue or PR as relevant to SIG Node. triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Nov 15, 2021
@k8s-ci-robot k8s-ci-robot added area/test sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Nov 15, 2021
@verb
Copy link
Contributor Author

verb commented Nov 15, 2021

failures are not from the ephemeral containers test

/retest

@manugupt1
Copy link
Contributor

Looks good to me. thanks for making the change.

@verb
Copy link
Contributor Author

verb commented Nov 15, 2021

/assign @SergeyKanzhelev

SergeyKanzhelev
SergeyKanzhelev approved these changes Nov 15, 2021
View reviewed changes
Copy link
Member

@SergeyKanzhelev SergeyKanzhelev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for a quick turnaround

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SergeyKanzhelev, verb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 15, 2021
@SergeyKanzhelev
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 15, 2021
@SergeyKanzhelev SergeyKanzhelev moved this from Triage to Done in SIG Node CI/Test Board Nov 15, 2021
@k8s-ci-robot k8s-ci-robot merged commit 7ac7683 into kubernetes:master Nov 15, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Nov 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SergeyKanzhelev SergeyKanzhelev SergeyKanzhelev approved these changes

@derekwaynecarr derekwaynecarr Awaiting requested review from derekwaynecarr

@feiskyer feiskyer Awaiting requested review from feiskyer

Assignees

@SergeyKanzhelev SergeyKanzhelev

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. kind/flake Categorizes issue or PR as related to a flaky test. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Node CI/Test Board
Done
SIG Node CI/Test Board
Archived in project
Milestone
v1.23
Development

Successfully merging this pull request may close these issues.

[NodeFeature:EphemeralContainers] Ephemeral Containers e2e tests are Flaking
4 participants
@verb @manugupt1 @k8s-ci-robot @SergeyKanzhelev