Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #104287: Reduce calls to docker from dockershim for stats #106504

Merged
merged 1 commit into from Dec 1, 2021
Merged

Automated cherry pick of #104287: Reduce calls to docker from dockershim for stats #106504

merged 1 commit into from Dec 1, 2021

Conversation

jsturtevant
Copy link
Contributor

Cherry pick of #104287 on release-1.20.

#104287: Reduce calls to docker from dockershim for stats

For details on the cherry pick process, see the cherry pick requests page.

@k8s-ci-robot k8s-ci-robot added this to the v1.20 milestone Nov 17, 2021
@k8s-ci-robot k8s-ci-robot added do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 17, 2021
@k8s-ci-robot k8s-ci-robot added area/kubelet sig/node Categorizes an issue or PR as relevant to SIG Node. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Nov 17, 2021
@jsturtevant jsturtevant force-pushed the automated-cherry-pick-of-#104287-upstream-release-1.20 branch from 75aa74a to 5d05800 Compare November 17, 2021 19:51
@jsturtevant jsturtevant force-pushed the automated-cherry-pick-of-#104287-upstream-release-1.20 branch from 5d05800 to f5dede7 Compare November 17, 2021 21:18
@marosset
Copy link
Contributor

/sig windows
/lgtm

@k8s-ci-robot k8s-ci-robot added the sig/windows Categorizes an issue or PR as relevant to SIG Windows. label Nov 17, 2021
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 17, 2021
@marosset marosset added this to Open backport PRs in SIG-Windows Nov 18, 2021
@SergeyKanzhelev
Copy link
Member

@marosset

can you please update this and other cherry picks for this PR with the priority, kind, and short explanation why it satisfy the cherry-pick bar: https://github.com/kubernetes/community/blob/master/contributors/devel/sig-release/cherry-picks.md#what-kind-of-prs-are-good-for-cherry-picks

@marosset
Copy link
Contributor

/priority critical-urgent
/kind bug
/triage accepted

Dockershim creates a new namedpipe (socket) on every docker call causing unnecessary disk reads, high CPU usage, and extra latency on stats calls.
This PR reduced duplicate calls dockershim endpoints improving the overall performance and stability of Windows nodes using dockershim.

@ehashman
Copy link
Member

/priority critical-urgent
/kind bug
/triage accepted

@k8s-ci-robot k8s-ci-robot added priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. kind/bug Categorizes issue or PR as related to a bug. triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Nov 29, 2021
@k8s-ci-robot k8s-ci-robot removed the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Nov 29, 2021
@ehashman ehashman moved this from Triage to Needs Approver in SIG Node PR Triage Nov 29, 2021
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 29, 2021
@jsturtevant
Copy link
Contributor Author

/assign @kubernetes/release-managers

cpanato
cpanato approved these changes Dec 1, 2021
View reviewed changes
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@cpanato cpanato added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Dec 1, 2021
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Dec 1, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, jsturtevant, mrunalp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit a7b9fd5 into kubernetes:release-1.20 Dec 1, 2021
SIG-Windows automation moved this from Open backport PRs to Done (v1.23) Dec 1, 2021
SIG Node PR Triage automation moved this from Needs Approver to Done Dec 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrunalp mrunalp mrunalp approved these changes

@cpanato cpanato cpanato approved these changes

@derekwaynecarr derekwaynecarr Awaiting requested review from derekwaynecarr

@vishh vishh Awaiting requested review from vishh

Assignees

@cpanato cpanato

@marosset marosset

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubelet cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/windows Categorizes an issue or PR as relevant to SIG Windows. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Node PR Triage
Done
SIG-Windows
  
Done (v1.23)
Milestone
v1.20
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@jsturtevant @marosset @SergeyKanzhelev @ehashman @k8s-ci-robot @mrunalp @cpanato