Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ineligible_endpoints.yaml to include HPA #107349

Merged
merged 1 commit into from
Jan 6, 2022

Conversation

riaankleinhans
Copy link
Contributor

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
Add HPA to ineligible_endpoint.yaml as it is an optional feature

Special notes for your reviewer:
As of 1.22 APISnoop Ineligible endpoints are pulled from the community owned inelegible_endpoint.yaml file

Does this PR introduce a user-facing change?:

NONE

Release note:

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

NONE

/sig architecture
/area conformance

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. area/conformance Issues or PRs related to kubernetes conformance tests cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jan 5, 2022
@riaankleinhans
Copy link
Contributor Author

/triage accepted

@riaankleinhans
Copy link
Contributor Author

/assign @johnbelamaric @smarterclayton

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jan 5, 2022
@riaankleinhans riaankleinhans changed the title Update ineligible_endpoints.yaml Update ineligible_endpoints.yaml to include HPA Jan 5, 2022
@riaankleinhans
Copy link
Contributor Author

/test pull-kubernetes-unit

Unreleated flake

=== Failed
=== FAIL: pkg/controller/statefulset TestStatefulSetControlRollingUpdateWithPartition/Delete/StatefulSetAutoDeletePVCEnabled (0.71s)
W0105 21:40:05.702793   52374 mutation_detector.go:53] Mutation detector is enabled, this will result in memory leakage.
W0105 21:40:05.702908   52374 mutation_detector.go:53] Mutation detector is enabled, this will result in memory leakage.
W0105 21:40:05.702987   52374 mutation_detector.go:53] Mutation detector is enabled, this will result in memory leakage.
W0105 21:40:05.703050   52374 mutation_detector.go:53] Mutation detector is enabled, this will result in memory leakage.
W0105 21:40:06.130605   52374 mutation_detector.go:53] Mutation detector is enabled, this will result in memory leakage.
W0105 21:40:06.130899   52374 mutation_detector.go:53] Mutation detector is enabled, this will result in memory leakage.
W0105 21:40:06.131038   52374 mutation_detector.go:53] Mutation detector is enabled, this will result in memory leakage.
W0105 21:40:06.131180   52374 mutation_detector.go:53] Mutation detector is enabled, this will result in memory leakage.
    stateful_set_control_test.go:1243: monotonic image update and scale up: persistentvolumeclaim "datadir-foo-0" not found
    --- FAIL: TestStatefulSetControlRollingUpdateWithPartition/Delete/StatefulSetAutoDeletePVCEnabled (0.71s)
=== FAIL: pkg/controller/statefulset TestStatefulSetControlRollingUpdateWithPartition (13.08s)

@johnbelamaric
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 5, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johnbelamaric, Riaankl

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 5, 2022
@oomichi
Copy link
Member

oomichi commented Jan 6, 2022

Nice addition.

/retest
/lgtm

@k8s-ci-robot k8s-ci-robot merged commit 1c2f24f into kubernetes:master Jan 6, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.24 milestone Jan 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/conformance Issues or PRs related to kubernetes conformance tests cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants