Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

csi: correct struct fields in CSI{Persistent}VolumeSource. #107385

Merged
merged 1 commit into from
Jan 7, 2022
Merged

csi: correct struct fields in CSI{Persistent}VolumeSource. #107385

merged 1 commit into from
Jan 7, 2022

Conversation

humblec
Copy link
Contributor

@humblec humblec commented Jan 6, 2022 •
edited

The field names in godoc for CSIPersistentVolumeSource and
CSIVolumeSource has been corrected with this commit.

Additional Ref# #105963 (comment)

Signed-off-by: Humble Chirammal hchiramm@redhat.com

What type of PR is this?

/kind cleanup
/kind documentation

-->

NONE

Additional Note:

There are more structs to fix, it will be done as a follow up PRs.

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. kind/documentation Categorizes issue or PR as related to documentation. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jan 6, 2022
@k8s-ci-robot
Copy link
Contributor

@humblec: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Jan 6, 2022
@humblec
Copy link
Contributor Author

humblec commented Jan 6, 2022

/sig storage

@k8s-ci-robot k8s-ci-robot added sig/storage Categorizes an issue or PR as relevant to SIG Storage. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jan 6, 2022
@k8s-ci-robot k8s-ci-robot added the kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API label Jan 6, 2022
@humblec
Copy link
Contributor Author

humblec commented Jan 6, 2022

/assign @smarterclayton
/assign @liggitt

@humblec
Copy link
Contributor Author

humblec commented Jan 6, 2022

/test pull-kubernetes-unit

@k8s-triage-robot
Copy link

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

liggitt
liggitt reviewed Jan 6, 2022
View reviewed changes
Copy link
Member

@liggitt liggitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good overall, commented on a few missed fields

staging/src/k8s.io/api/core/v1/types.go Show resolved Hide resolved
staging/src/k8s.io/api/core/v1/types.go Outdated Show resolved Hide resolved
staging/src/k8s.io/api/core/v1/types.go Show resolved Hide resolved
@humblec
csi: correct struct fields in CSI{Persistent}VolumeSource.
e01753a 
The field names in godoc for CSIPersistentVolumeSource and
CSIVolumeSource has been corrected with this commit.

Additional Ref# kubernetes#105963 (comment)

Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 7, 2022
@humblec
Copy link
Contributor Author

humblec commented Jan 7, 2022

looks good overall, commented on a few missed fields

Thanks @liggitt , I have addressed the comments, ptal. thanks!

@liggitt
Copy link
Member

liggitt commented Jan 7, 2022

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 7, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: humblec, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 7, 2022
@humblec
Copy link
Contributor Author

humblec commented Jan 7, 2022

/test pull-kubernetes-unit

@humblec
Copy link
Contributor Author

humblec commented Jan 7, 2022

/test pull-kubernetes-e2e-kind

@k8s-ci-robot k8s-ci-robot merged commit 7846bbb into kubernetes:master Jan 7, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.24 milestone Jan 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liggitt liggitt liggitt left review comments

@thockin thockin Awaiting requested review from thockin

Assignees

@liggitt liggitt

@smarterclayton smarterclayton

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.24
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@humblec @k8s-ci-robot @k8s-triage-robot @liggitt @smarterclayton