Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Order suggested FlowSchemas by matching precedence #107510

Merged
merged 1 commit into from
Jan 13, 2022
Merged

Order suggested FlowSchemas by matching precedence #107510

merged 1 commit into from
Jan 13, 2022

Conversation

MikeSpreitzer
Copy link
Member

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

This PR just moves some FlowSchema definitions around in apiserver/pkg/apis/flowcontrol/bootstrap/default.go, so that they are ordered by increasing matching precedence. That makes it easier to imagine their interactions while reading the source file.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Jan 13, 2022
@MikeSpreitzer
Copy link
Member Author

@kubernetes/sig-api-machinery-misc
/cc @wojtek-t
/cc @tkashem
/cc @deads2k
@liggitt
@lavalamp

@k8s-ci-robot k8s-ci-robot added sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jan 13, 2022
@k8s-ci-robot k8s-ci-robot added the kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API label Jan 13, 2022
@liggitt
Copy link
Member

liggitt commented Jan 13, 2022

is interruption of the git history worth the reordering? (maybe so, I just thought I'd ask)

@MikeSpreitzer
Copy link
Member Author

Speaking only for myself, I find it much easier to understand the interactions among the schemas when they appear in matching precedence order.

The potential lossage in git is the disappearance of some comments in the "Files changed" view but not in the "Conversation" view, right? I am willing to sacrifice that to make the source easier to understand.

@k8s-triage-robot
Copy link

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

@wojtek-t
Copy link
Member

is interruption of the git history worth the reordering? (maybe so, I just thought I'd ask)

I don't have strong opinion - I'm fine either way.

@liggitt
Copy link
Member

liggitt commented Jan 13, 2022

I don't have strong opinion - I'm fine either way.

sounds good. @wojtek-t, can you review and I'll tag once this has lgtm

@wojtek-t
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 13, 2022
@liggitt
Copy link
Member

liggitt commented Jan 13, 2022

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, MikeSpreitzer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 13, 2022
@MikeSpreitzer
Copy link
Member Author

/retest

@k8s-ci-robot k8s-ci-robot merged commit 0669da4 into kubernetes:master Jan 13, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.24 milestone Jan 13, 2022
@fedebongio
Copy link
Contributor

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jan 13, 2022
@MikeSpreitzer MikeSpreitzer deleted the order-flow-schemas branch January 13, 2022 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deads2k deads2k Awaiting requested review from deads2k

@tkashem tkashem Awaiting requested review from tkashem

@wojtek-t wojtek-t Awaiting requested review from wojtek-t

@derekwaynecarr derekwaynecarr Awaiting requested review from derekwaynecarr

@sttts sttts Awaiting requested review from sttts

Assignees

@wojtek-t wojtek-t

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.24
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@MikeSpreitzer @liggitt @k8s-triage-robot @wojtek-t @k8s-ci-robot @fedebongio