ANSI escape characters in kubectl output annotation are not being filtered -

[zishen]

What happened?

The same phenomenon with #101695 ,but in pod and node annotation.

What did you expect to happen?

The ANSI escape characters will be filtered so they couldn't affect the terminal (i.e. using embeded ANSI colors won't do anything to the terminal).

How can we reproduce it (as minimally and precisely as possible)?

run this :
pod:

describe the pod:

Anything else we need to know?

ANSI escape characters were used to abuse terminals emulators and even cause code execution if the terminal is vulnerable(like CVE-2021-25743)

Kubernetes version

Client Version: version.Info{Major:"1", Minor:"18", GitVersion:"v1.18.0", GitCommit:"9e991415386e4cf155a24b1da15becaa390438d8", GitTreeState:"clean", BuildDate:"2020-03-25T14:58:59Z", GoVersion:"go1.13.8", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"18", GitVersion:"v1.18.0", GitCommit:"9e991415386e4cf155a24b1da15becaa390438d8", GitTreeState:"clean", BuildDate:"2020-03-25T14:50:46Z", GoVersion:"go1.13.8", Compiler:"gc", Platform:"linux/amd64"}

Cloud provider

Huwei

OS version

# On Linux:
$ cat /etc/os-release
# paste output here
$ uname -a
# paste output here

# On Windows:
C:\> wmic os get Caption, Version, BuildNumber, OSArchitecture
# paste output here

Install tools

Container runtime (CRI) and and version (if applicable)

Related plugins (CNI, CSI, ...) and versions (if applicable)

[zishen]

/sig api-machinery

[neolit123]

Client Version: version.Info{Major:"1", Minor:"18", GitVersion:"v1.18.0", GitCommit:"9e991415386e4cf155a24b1da15becaa390438d8", GitTreeState:"clean", BuildDate:"2020-03-25T14:58:59Z", GoVersion:"go1.13.8", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"18", GitVersion:"v1.18.0", GitCommit:"9e991415386e4cf155a24b1da15becaa390438d8", GitTreeState:"clean", BuildDate:"2020-03-25T14:50:46Z", GoVersion:"go1.13.8", Compiler:"gc", Platform:"linux/amd64"}

1.18 is out of support. is this reproducible with >= 1.20?

/sig cli
(for kubectl)

[zishen]

yes， the same in v1.22.2

[liggitt]

I think we only need a single issue to track this.

[liggitt]

/close
in favor of #101695

[k8s-ci-robot]

@liggitt: Closing this issue.

In response to this:

/close
in favor of #101695

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[sftim]

/triage duplicate

[fedebongio]

/triage accepted