client-go: Scale() constructor for ScaleApplyConfiguration missing WithKind, WithAPIVersion

[mgabeler-lee-6rs]

What happened?

Most of the FooApplyConfiguration constructors pre-fill the Kind and APIVersion fields to make using them smooth.

But k8s.io/client-go/applyconfigurations/autoscaling/v1.Scale() is missing this, making patterns like this fail:

	_, err = deployments.ApplyScale(
		ctx, deploymentName,
		scaleV1.Scale().
			WithSpec(
				scaleV1.ScaleSpec().WithReplicas(0),
			),
		opts,
	)

Currently this code fails with (server-side) error Incorrect version specified in apply patch. Specified patch version: , expected: autoscaling/v1.

What did you expect to happen?

The Scale() constructor should set the minimum required fields for the resulting object to be usable with ApplyScale() calls, similar to how e.g. the `D

How can we reproduce it (as minimally and precisely as possible)?

• Create a deployment (however)
• Create a clientset, and get the Deployments client from it
• Try to call deployments.ApplyScale using a ScaleApplyConfiguration created by the Scale() constructor

Anything else we need to know?

I can see that the presence or absence of these metadata fields is driven by some code generation, but I wasn't able to follow through to what configures that code generation. I assume it's something in the schemas somewhere, but that wasn't clear to me.

Kubernetes version

$ kubectl version
Client Version: version.Info{Major:"1", Minor:"23", GitVersion:"v1.23.2", GitCommit:"9d142434e3af351a628bffee3939e64c681afa4d", GitTreeState:"clean", BuildDate:"2022-01-19T17:35:46Z", GoVersion:"go1.17.5", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"23", GitVersion:"v1.23.1", GitCommit:"86ec240af8cbd1b60bcc4c03c20da9b98005b92e", GitTreeState:"clean", BuildDate:"2021-12-16T11:34:54Z", GoVersion:"go1.17.5", Compiler:"gc", Platform:"linux/amd64"}

Cloud provider

minikube v1.25.1

OS version

N/A

Install tools

N/A

Container runtime (CRI) and and version (if applicable)

N/A

Related plugins (CNI, CSI, ...) and versions (if applicable)

N/A

[mgabeler-lee-6rs]

/sig api-machinery

[fedebongio]

/assign @jpbetz
/triage accepted

[jpbetz]

/assign