Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

code-generator: fix the bug that ApplyConfiguration constructor missing WithKind/WithAPIVersion methods #107834

Merged
merged 1 commit into from Feb 8, 2022
Merged

code-generator: fix the bug that ApplyConfiguration constructor missing WithKind/WithAPIVersion methods #107834

merged 1 commit into from Feb 8, 2022

Conversation

SataQiu
Copy link
Member

@SataQiu SataQiu commented Jan 28, 2022

What type of PR is this?

/kind bug

What this PR does / why we need it:

code-generator: fix the bug that ApplyConfiguration constructor missing WithKind/WithAPIVersion methods

Which issue(s) this PR fixes:

Fixes #107795

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. and removed do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Jan 28, 2022
@k8s-ci-robot k8s-ci-robot added area/code-generation sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jan 28, 2022
@liggitt
Copy link
Member

liggitt commented Jan 29, 2022

integration timeout flake tracked in #107857

@MadhavJivrajani
Copy link
Contributor

/assign @jpbetz

@MadhavJivrajani
Copy link
Contributor

/retest

@fedebongio
Copy link
Contributor

/triage accepted
thank you Joe!

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Feb 1, 2022
@SataQiu
Copy link
Member Author

SataQiu commented Feb 3, 2022

/test pull-kubernetes-integration

@SataQiu
Copy link
Member Author

SataQiu commented Feb 7, 2022

kindly ping @jpbetz

@jpbetz
Copy link
Contributor

jpbetz commented Feb 7, 2022

/lgtm

This looks right

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 7, 2022
@jpbetz
Copy link
Contributor

jpbetz commented Feb 8, 2022

/priority important-soon

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Feb 8, 2022
@SataQiu
Copy link
Member Author

SataQiu commented Feb 8, 2022

kindly ping @liggitt for approve

liggitt
liggitt reviewed Feb 8, 2022
View reviewed changes
Copy link
Member

@liggitt liggitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

staging/src/k8s.io/client-go/applyconfigurations/meta/v1/deleteoptions.go
@@ -36,7 +36,10 @@ type DeleteOptionsApplyConfiguration struct {
// DeleteOptionsApplyConfiguration constructs an declarative configuration of the DeleteOptions type for use with
// apply.
func DeleteOptions() *DeleteOptionsApplyConfiguration {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pre-existing, but apply configuration for delete options is weird, right? we can't actually submit this object to server-side apply

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I remember squinting at this one when I originally added apply configurations. The apply configurations generator uses a reachability routine to figure out which types to include. It includes delete options because of

kubernetes/staging/src/k8s.io/api/policy/v1/types.go

Line 171 in 6a5b3da

DeleteOptions *metav1.DeleteOptions `json:"deleteOptions,omitempty" protobuf:"bytes,2,opt,name=deleteOptions"`

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, SataQiu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 8, 2022
@k8s-ci-robot k8s-ci-robot merged commit 20a2a4c into kubernetes:master Feb 8, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.24 milestone Feb 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpbetz jpbetz jpbetz left review comments

@liggitt liggitt liggitt left review comments

@sttts sttts Awaiting requested review from sttts

@wojtek-t wojtek-t Awaiting requested review from wojtek-t

Assignees

@jpbetz jpbetz

@liggitt liggitt

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/code-generation cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.24
Development

Successfully merging this pull request may close these issues.

client-go: Scale() constructor for ScaleApplyConfiguration missing WithKind, WithAPIVersion
6 participants
@SataQiu @liggitt @MadhavJivrajani @fedebongio @jpbetz @k8s-ci-robot