Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating the test framework to ginkgo 2.0 #107936

Closed
3 tasks
johnSchnake opened this issue Feb 3, 2022 · 8 comments · Fixed by #109111
Closed
3 tasks

Updating the test framework to ginkgo 2.0 #107936

johnSchnake opened this issue Feb 3, 2022 · 8 comments · Fixed by #109111
Labels
area/e2e-test-framework Issues or PRs related to refactoring the kubernetes e2e test framework kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. sig/testing Categorizes an issue or PR as relevant to SIG Testing.

Comments

@johnSchnake
Copy link
Contributor

What would you like to be added?

Updating the test framework to ginkgo 2.0 will eventually happen I'm sure and I just wanted to have some notes related to this that people can reference.

Why is this needed?

Just tracking issues that would be related to any updating of ginkgo from 1.0 to 2.0.
@johnSchnake johnSchnake added the kind/feature Categorizes issue or PR as related to a new feature. label Feb 3, 2022
@k8s-ci-robot k8s-ci-robot added needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Feb 3, 2022
@k8s-ci-robot
Copy link
Contributor

@johnSchnake: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@johnSchnake
Copy link
Contributor Author

/area e2e-framework
/sig testing

@k8s-ci-robot k8s-ci-robot added the sig/testing Categorizes an issue or PR as relevant to SIG Testing. label Feb 3, 2022
@k8s-ci-robot
Copy link
Contributor

@johnSchnake: The label(s) area/e2e-framework cannot be applied, because the repository doesn't have them.

In response to this:

/area e2e-framework
/sig testing

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot removed the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Feb 3, 2022
@johnSchnake
Copy link
Contributor Author

/area e2e-test-framework

@k8s-ci-robot k8s-ci-robot added the area/e2e-test-framework Issues or PRs related to refactoring the kubernetes e2e test framework label Feb 3, 2022
@johnSchnake
Copy link
Contributor Author

/kind cleanup

@k8s-ci-robot k8s-ci-robot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Feb 3, 2022
@johnSchnake
Copy link
Contributor Author

/remove-kind feature

@k8s-ci-robot k8s-ci-robot removed the kind/feature Categorizes issue or PR as related to a new feature. label Feb 3, 2022
@aojea
Copy link
Member

aojea commented Feb 3, 2022

For the ones interested, ginkgov2 was already tested against Kubernetes and works, it does requires some changes though

#105147

Most of the work required is to adapt the reporters

@aojea aojea mentioned this issue Feb 16, 2022
Closed
@chendave chendave mentioned this issue Mar 30, 2022
Merged
@chendave
Copy link
Member

chendave commented Mar 30, 2022 •
edited

This will be addressed in this pr: #109111

A separated pr will dedicatedly address the reporter migration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/e2e-test-framework Issues or PRs related to refactoring the kubernetes e2e test framework kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. sig/testing Categorizes an issue or PR as relevant to SIG Testing.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Migrate Ginkgo from v1 to v2 chendave/kubernetes
4 participants
@chendave @aojea @johnSchnake @k8s-ci-robot