-
Notifications
You must be signed in to change notification settings - Fork 38.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cacher: Minor cleanup and refactor of code and tests #108042
cacher: Minor cleanup and refactor of code and tests #108042
Conversation
/lgtm Thanks! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: MadhavJivrajani, wojtek-t The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
/lgtm cancel Verify failure is related - please fix. |
* Remove linter warnings. * Cancel contexts to avoid leaks. * Rename a few XXXThreadUnsafe to XXXLocked to maintain consistency. * A few are still called XXXThreadUnsafe mainly because those are safe to be called from the perspective that only one gorotuine will access them - not really called under a lock. Signed-off-by: Madhav Jivrajani <madhav.jiv@gmail.com>
d03e19e
to
c3081b4
Compare
/lgtm |
/triage accepted |
What type of PR is this?
/kind cleanup
/priority backlog
/sig api-machinery
What this PR does / why we need it:
maintain consistency.
because those are safe to be called from the
perspective that only one gorotuine will access
them - not really called under a lock.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:
/assign @wojtek-t
minor cleanups based on watch cache interval PR reviews + additional ones that I could find :)