fix: do not return early in the node informer when there is no change… #108149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note
k8s-ci-robot
added
sig/cloud-provider
|
/assign @feiskyer |
|
/assign @andyzhangx |
… of the topology label.
k8s-ci-robot
added
size/M
|
/sig cloud-provider |
k8s-ci-robot
added
triage/accepted
feiskyer
approved these changes
Feb 16, 2022
k8s-ci-robot
added
the
lgtm
|
/assign @andrewsykim |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andrewsykim, feiskyer, nilo19 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
That's great, @feiskyer, thanks a lot! Could you also backport it all the way to 1.20 (except for 1.21...I see that, for some reason, there is no check against topology labels in 1.21)? Thanks! |
|
/cherrypick release-1.23 |
|
@ricky-rav 1.20 is not active now per https://kubernetes.io/releases/patch-releases/, but we should cherry-pick to other active branches. |
k8s-ci-robot
added a commit
that referenced
this pull request
Mar 3, 2022
…49-upstream-release-1.23 Automated cherry pick of #108149: fix: do not return early in the node informer when there is
k8s-ci-robot
added a commit
that referenced
this pull request
Mar 3, 2022
…49-upstream-release-1.22 Automated cherry pick of #108149: fix: do not return early in the node informer when there is
liggitt
added
the
kind/regression
This was referenced May 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… of the topology label.
What type of PR is this?
/kind bug
What this PR does / why we need it:
The node cache will not be updated if there is no change of the topology label, which is not expected.
Which issue(s) this PR fixes:
Fixes #108112
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: