storage: etcd: use cmp.Diff for comparisons #108187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note-none
|
/assign |
k8s-ci-robot
added
triage/accepted
stevekuznetsov
force-pushed
the
skuznets/storage-tests-diff
branch
from
2c973c7
to
07e641a
Compare
This commit simply modernizes the comparisons made in the storage tests to use `cmp.Diff()` so that pointer comparisons and length checks do not have to be made by hand. We also get nice diffs in the test output this way instead of large pasted blobs. Signed-off-by: Steve Kuznetsov <skuznets@redhat.com>
|
@smarterclayton done |
stevekuznetsov
force-pushed
the
skuznets/storage-tests-diff
branch
from
07e641a
to
dfdd486
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: smarterclayton, stevekuznetsov The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit simply modernizes the comparisons made in the storage tests
to use
cmp.Diff()so that pointer comparisons and length checks do nothave to be made by hand. We also get nice diffs in the test output this
way instead of large pasted blobs.
Signed-off-by: Steve Kuznetsov skuznets@redhat.com
/kind cleanup
/sig api-machinery
/cc @deads2k @liggitt @enj