storage: etcd: clarify lease manager configurations #108214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the original commit created the lease manager, this comment was added to set the default test reuse time to 1s. Even at that time, the comment claimed it was setting 10s. Instead of using this value, though, new tests that did not call `testSetup()` started to use the default configuration for production. This commit clarifies the intent of this comment, moves it next to the code block that it actually applies to, and makes use of this test-specific logic everywhere. x-ref: f230b000db5798397d620c141babeafebd31a64b Signed-off-by: Steve Kuznetsov <skuznets@redhat.com>
k8s-ci-robot
added
release-note-none
|
/test pull-kubernetes-e2e-kind-ipv6 |
|
cc @wenjiaswe |
k8s-ci-robot
added
triage/accepted
|
@smarterclayton @jpbetz @wenjiaswe would any of you be available to review this? |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: smarterclayton, stevekuznetsov The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the original commit created the lease manager, this comment was
added to set the default test reuse time to 1s. Even at that time, the
comment claimed it was setting 10s. Instead of using this value, though,
new tests that did not call
testSetup()started to use the defaultconfiguration for production. This commit clarifies the intent of this
comment, moves it next to the code block that it actually applies to,
and makes use of this test-specific logic everywhere.
x-ref: f230b000db5798397d620c141babeafebd31a64b
Signed-off-by: Steve Kuznetsov skuznets@redhat.com
/kind cleanup
/sig api-machinery
/cc @deads2k @liggitt @sttts