Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support ExtenderName in FakeExtender #108230

Merged
merged 1 commit into from
Feb 23, 2022
Merged

Support ExtenderName in FakeExtender #108230

merged 1 commit into from
Feb 23, 2022

Conversation

sanposhiho
Copy link
Member

What type of PR is this?

/kind feature

What this PR does / why we need it:

The name of Extender should be unique. There is no way to specify FakeExtender's name and all FakeExtender's name is "FakeExtender". This PR supports ExtenderName in FakeExtender to allow to specify FakeExtender's name.

Currently, There are no issue with this because in k/k no one is using Name() func on Extender.
But, #107984 adds top 3 score of node in event message and will use Name() method on Extender to get Extender's name for event messages. Therefore, #107984 needs the way to specify FakeExtender's name for unit tests.

(I implemented this feature in #107984, but #107984 is big and difficult to review because of that. Therefore, I'm considering splitting #107984 into multiple PRs. This PR is one of them.)

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/feature Categorizes issue or PR as related to a new feature. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. and removed do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Feb 20, 2022
@k8s-ci-robot
Copy link
Contributor

@sanposhiho: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Feb 20, 2022
@sanposhiho
Copy link
Member Author

/sig scheduling

@k8s-ci-robot k8s-ci-robot added sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Feb 20, 2022
@sanposhiho
Copy link
Member Author

/retest

@k8s-triage-robot
Copy link

Unknown CLA label state. Rechecking for CLA labels.

Send feedback to sig-contributor-experience at kubernetes/community.

/check-cla
/easycla

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 20, 2022
denkensk
denkensk reviewed Feb 21, 2022
View reviewed changes
pkg/scheduler/extender_test.go Outdated
@@ -58,10 +58,12 @@ func TestGenericSchedulerWithExtenders(t *testing.T) {
},
extenders: []st.FakeExtender{
{
Predicates: []st.FitPredicate{st.TruePredicateExtender},
ExtenderName: "FakeExtenderName1",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FakeExtender1 is more concise.

pkg/scheduler/testing/fake_extender.go Outdated
@@ -155,9 +158,15 @@ type FakeExtender struct {
CachedNodeNameToInfo map[string]*framework.NodeInfo
}

const defaultExtenderName = "FakeExtender"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

const defaultFakeExtenderName = "defaultFakeExtender" ?

kerthcet
kerthcet reviewed Feb 21, 2022
View reviewed changes
pkg/scheduler/extender_test.go Outdated
@@ -134,6 +142,7 @@ func TestGenericSchedulerWithExtenders(t *testing.T) {
},
extenders: []st.FakeExtender{
{
ExtenderName: "FakeExtenderName1",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if we have default ExtenderName, do we need this?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Of course, it will work without it, but I think it's better to have it.
(For example, if someone wants to add new test case with reference to existing test cases, he/she can notice that it (may) need ExtenderName.)

alculquicondor
alculquicondor reviewed Feb 22, 2022
View reviewed changes
Copy link
Member

@alculquicondor alculquicondor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Will leave LGTM to already involved reviewers.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alculquicondor, sanposhiho

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 22, 2022
@sanposhiho
Copy link
Member Author

@denkensk @kerthcet

I addressed (and replied to) your reviews. Please take another look.

@kerthcet
Copy link
Member

Great, leave LGTM to @denkensk and don't forget to squash the commits. Thanks @sanposhiho

@denkensk
Copy link
Member

/lgtm
Thanks. @sanposhiho

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 23, 2022
@kerthcet
Copy link
Member

/retest

@k8s-ci-robot k8s-ci-robot merged commit 296bf4f into kubernetes:master Feb 23, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.24 milestone Feb 23, 2022
@sanposhiho sanposhiho mentioned this pull request Feb 24, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alculquicondor alculquicondor alculquicondor left review comments

@denkensk denkensk denkensk left review comments

@kerthcet kerthcet kerthcet left review comments

Assignees

@denkensk denkensk

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.24
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@sanposhiho @k8s-ci-robot @k8s-triage-robot @kerthcet @denkensk @alculquicondor