New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve unit test coverage in pkg/util/taints/
#108332
Improve unit test coverage in pkg/util/taints/
#108332
Conversation
/sig testing |
765de24
to
a521c20
Compare
pkg/util/tail/
pkg/util/taint/
pkg/util/taint/
pkg/util/taints/
/assign @dchen1107 |
/kind cleanup |
a521c20
to
d878288
Compare
Rebased. |
d878288
to
3b2b43d
Compare
/retest |
ping @lavalamp @dchen1107 |
This PR has been waiting for a review for a long time. Could you please take a look at this PR?@dchen1107 @dims @lavalamp @smarterclayton @thockin |
/unassign feel free to proceed without my review. |
Please review again and determine if you can agree. Thanks! @MadhavJivrajani |
The modification has been completed. Request approval @dims @MadhavJivrajani |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work
/triage accepted
/lgtm
5a1d22c
to
88e2fc7
Compare
88e2fc7
to
8490488
Compare
PR #112436 has been merged, and the taints package test coverage has become 100%
|
Thanks for separating the pull request. This new one seems simpler than the previous one. /lgtm |
just a nit, lgtm /assign @liggitt |
8490488
to
19989df
Compare
… easily be changed and improve unit test coverage in `pkg/util/taints/taints_test.go`
19989df
to
1b9e4eb
Compare
/approve |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: liggitt, mengjiao-liu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
The changes are as follows:
Run test coverage command:
Befor:
After(When unused methods are removed, test coverage becomes 100% #112436):
Which issue(s) this PR fixes:
Ref #97355
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: