-
Notifications
You must be signed in to change notification settings - Fork 38.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump konnectivity-client to v0.0.28 #108339
Conversation
Bump konnectivity network proxy to v0.0.28. Includes a fix to ensure the KAS calls Close() on the egress connection.
/priority important-soon |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
For the record, @rata and I are still investigating some remaining leaks in kubernetes-sigs/apiserver-network-proxy#276, but given this fixes a significant goroutine leak (specifically when proxy server restarts) and seems safe/obvious I think we should still backport it.
Unknown CLA label state. Rechecking for CLA labels. Send feedback to sig-contributor-experience at kubernetes/community. /check-cla |
@andrewsykim for other leaks (like when we upgraded to 0.0.27 was also for a leak), we back-ported the changes to all supported versions (it was requested by the release team to do it for all branches at the same time). I don't think anyone will oppose to do the same now, once this is merged :) |
/assign @liggitt |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cheftako, liggitt The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass. This bot retests PRs for certain kubernetes repos according to the following rules:
You can:
/retest |
For the record, I can confirm this PR fixes too the issue when proxy-server is down for a few minutes. With this PR, when proxy-server starts again, the number of proxy connections established from the apiserver is the expected. Without this PR, the number of connections grows as the proxy-server is down for more time. |
/triage accepted |
What type of PR is this?
/kind feature
What this PR does / why we need it:
Bump konnectivity network proxy to v0.0.28.
Includes a fix to ensure the KAS calls Close() on the egress connection.
Pulls in updates ANP binary fixes (https://github.com/kubernetes-sigs/apiserver-network-proxy/commits/v0.0.28)
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: