Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move CEL openapi integration code out of third_party/forked/celopenapi/model/registry.go #108346

Closed
jpbetz opened this issue Feb 25, 2022 · 7 comments · Fixed by #109959
Closed

Move CEL openapi integration code out of third_party/forked/celopenapi/model/registry.go #108346

jpbetz opened this issue Feb 25, 2022 · 7 comments · Fixed by #109959
Assignees
@mk46
Labels
area/code-organization Issues or PRs related to kubernetes code organization sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@jpbetz
Copy link
Contributor

jpbetz commented Feb 25, 2022

We've made enough changes to the code in staging/src/k8s.io/apiextensions-apiserver/third_party/forked/celopenapi/model, that it's not really helpful to think of it as forked code.

More practically, having gofmt disabled make it inconvenient.

I'd like to move it out of third_party and into something like staging/src/k8s.io/apiextensions-apiserver/pkg/apiserver/schema/cel/model.
@k8s-ci-robot k8s-ci-robot added needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Feb 25, 2022
@jpbetz jpbetz mentioned this issue Feb 25, 2022
Merged
@MadhavJivrajani
Copy link
Contributor

/sig api-machinery
/area code-organization

@k8s-ci-robot k8s-ci-robot added sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. area/code-organization Issues or PRs related to kubernetes code organization and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Feb 25, 2022
@jpbetz
Copy link
Contributor Author

jpbetz commented Feb 25, 2022

/triage accepted
/sig api-machinery

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Feb 25, 2022
@mk46
Copy link
Member

mk46 commented May 11, 2022

I would like to work on this.
/assign

@mk46 mk46 mentioned this issue May 11, 2022
Merged
@jpbetz
Copy link
Contributor Author

jpbetz commented May 11, 2022 •
edited

Thanks @mk46. Would you coordinate with @jiahuif who is also considering moving some of the CEL code around to make some future work possible?

@mk46
Copy link
Member

mk46 commented May 12, 2022

Thanks @mk46. Would you coordinate with @jiahuif who is also considering moving some of the CEL code around to make some future work possible?

Sure. Thanks for considering me.

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 10, 2022
@mk46
Copy link
Member

mk46 commented Aug 10, 2022

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mk46 mk46

Labels
area/code-organization Issues or PRs related to kubernetes code organization sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
No milestone
5 participants
@jpbetz @MadhavJivrajani @k8s-ci-robot @mk46 @k8s-triage-robot