Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

csi: add unit tests for controllerPublishSecretRef name & namespace validation #108391

Merged
merged 3 commits into from
Mar 3, 2022
Merged

csi: add unit tests for controllerPublishSecretRef name & namespace validation #108391

merged 3 commits into from
Mar 3, 2022

Conversation

humblec
Copy link
Contributor

@humblec humblec commented Feb 28, 2022 •
edited 

Extra test conditions are added in CSIPersistentVolumeSource validation
for controllerPublishSecretRef and nodePublishSecretRef name and namespace to check
whether name field or namespace field is missing from the secretRef while
validating CSI PersistentVolumeSource. 

This PR also added  seperate validation for CSIVolumeSource.

Signed-off-by: Humble Chirammal hchiramm@redhat.com

/kind cleanup

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. sig/apps Categorizes an issue or PR as relevant to SIG Apps. labels Feb 28, 2022
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Feb 28, 2022
@humblec
Copy link
Contributor Author

humblec commented Feb 28, 2022

/sig storage

@k8s-ci-robot k8s-ci-robot added the sig/storage Categorizes an issue or PR as relevant to SIG Storage. label Feb 28, 2022
@humblec
Copy link
Contributor Author

humblec commented Feb 28, 2022

CC @gnufied @msau42

@humblec humblec changed the title csi: add unit tests for controllerPublish name & namespace csi: add unit tests for controllerPublishSecretRef name & namespace validation Feb 28, 2022
@humblec
Copy link
Contributor Author

humblec commented Feb 28, 2022

Cc @xing-yang

@humblec
Copy link
Contributor Author

humblec commented Mar 2, 2022

Cc @jsafrane

@jsafrane
Copy link
Member

jsafrane commented Mar 2, 2022

Can you please add similar tests for NodePublishSecretRef, so all fields have tests?

@humblec
Copy link
Contributor Author

humblec commented Mar 2, 2022

Can you please add similar tests for NodePublishSecretRef, so all fields have tests?

Sure @jsafrane 👍

@humblec
csi: correct typo and use strings.Repeat func for long driver name
8ae6e10 
Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 2, 2022
@humblec humblec force-pushed the pv-contrlpub branch 2 times, most recently from 1840d59 to 0ca76f8 Compare March 2, 2022 10:31
@humblec
csi: add unit tests for {controller,node}Publish name & namespace
1f0d37c 
Extra test conditions are added in CSIPersistentVolumeSource validation
for controllerPublishSecretRef and nodePublishSecretRef name and namespace to check
whether name field or namespace field is missing from the secretRef while
validating CSI PersistentVolumeSource

Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
@humblec
csi: add validation tests for CSIVolumeSource
d727d7d 
This commit adds the validation tests for CSIVolumeSource explictly.
Also validate driver,nodePublishSecretRef..etc

Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
@humblec
Copy link
Contributor Author

humblec commented Mar 2, 2022

@jsafrane added nodePublishSecretRef test to CSIPV validation and also splitted/added CSIVolumeSource validation tests with nodePublish. Thanks .. ptal..

@humblec
Copy link
Contributor Author

humblec commented Mar 2, 2022

/test pull-kubernetes-integration

@humblec
Copy link
Contributor Author

humblec commented Mar 2, 2022

Cc @liggitt

@humblec
Copy link
Contributor Author

humblec commented Mar 3, 2022

/test pull-kubernetes-integration

@liggitt
Copy link
Member

liggitt commented Mar 3, 2022

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 3, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: humblec, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 3, 2022
@humblec
Copy link
Contributor Author

humblec commented Mar 3, 2022

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Mar 3, 2022
@humblec
Copy link
Contributor Author

humblec commented Mar 3, 2022

Thanks !

@humblec
Copy link
Contributor Author

humblec commented Mar 3, 2022

/test pull-kubernetes-unit

@k8s-triage-robot
Copy link

The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass.

This bot retests PRs for certain kubernetes repos according to the following rules:

  • The PR does have any do-not-merge/* labels
  • The PR does not have the needs-ok-to-test label
  • The PR is mergeable (does not have a needs-rebase label)
  • The PR is approved (has cncf-cla: yes, lgtm, approved labels)
  • The PR is failing tests required for merge

You can:

/retest

@k8s-ci-robot k8s-ci-robot merged commit 8c1dc25 into kubernetes:master Mar 3, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.24 milestone Mar 3, 2022
@humblec humblec mentioned this pull request Mar 16, 2022
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pwittrock pwittrock Awaiting requested review from pwittrock

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

Assignees

@liggitt liggitt

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.24
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@humblec @jsafrane @liggitt @k8s-ci-robot @k8s-triage-robot