Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add gMSA Reading and Writing Files Test Case #108432

Merged
merged 1 commit into from
Mar 16, 2022
Merged

Add gMSA Reading and Writing Files Test Case #108432

merged 1 commit into from
Mar 16, 2022

Conversation

iXinqi
Copy link

@iXinqi iXinqi commented Mar 1, 2022 •
edited

What type of PR is this?

What this PR does / why we need it:

Add the file reading and writing test case into e2e GMSA tests. In this test case, the pod with GMSACredentialSpec should be able to read and write files from/to the remote folder in Active Directory server.

The assumptions of this test case are:

  • all the assumptions of the existing "works end to end" test case
  • there should be a folder created on Active Directory server and shared with the expected gMSA user.

Which issue(s) this PR fixes:

Fixes #100388

Special notes for your reviewer:

Does this PR introduce a user-facing change?

No

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

- KEP: https://github.com/kubernetes/enhancements/pull/2975

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Mar 1, 2022
@k8s-ci-robot
Copy link
Contributor

Welcome @iXinqi!

It looks like this is your first PR to kubernetes/kubernetes 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kubernetes has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @iXinqi. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/test sig/testing Categorizes an issue or PR as relevant to SIG Testing. sig/windows Categorizes an issue or PR as relevant to SIG Windows. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Mar 1, 2022
@k8s-triage-robot
Copy link

Unknown CLA label state. Rechecking for CLA labels.

Send feedback to sig-contributor-experience at kubernetes/community.

/check-cla
/easycla

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Mar 2, 2022 •
edited

CLA Signed

The committers are authorized under a signed CLA.

  • ✅ Xinqi Li (a08b055, 585d55051d38486d0b170c8f226f6db4117abf8d)

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Mar 2, 2022
@knabben
Copy link
Member

knabben commented Mar 2, 2022

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 2, 2022
@knabben knabben mentioned this pull request Mar 2, 2022
Closed
@iXinqi iXinqi force-pushed the add-write-file-test branch 3 times, most recently from dfd4a55 to 585d550 Compare March 3, 2022 20:30
@jsturtevant
Copy link
Contributor

This would resolve #100388

jsturtevant
jsturtevant suggested changes Mar 3, 2022
View reviewed changes
test/e2e/windows/gmsa_full.go Show resolved Hide resolved
test/e2e/windows/gmsa_full.go Outdated Show resolved Hide resolved
@jsturtevant
Copy link
Contributor

@iXinqi can you authorize the CLA?

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 12, 2022
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 15, 2022
@iXinqi
Copy link
Author

iXinqi commented Mar 16, 2022

/test pull-kubernetes-unit

@iXinqi
Copy link
Author

iXinqi commented Mar 16, 2022

/test pull-kubernetes-conformance-kind-ga-only-parallel

@marosset
Copy link
Contributor

/lgtm
/approve
/retest

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 16, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: iXinqi, knabben, marosset

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 16, 2022
@jsturtevant
Copy link
Contributor

/hold cancel
kubernetes-sigs/windows-testing#315 merged

/kind feature

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Mar 16, 2022
@k8s-ci-robot k8s-ci-robot merged commit 0b3629a into kubernetes:master Mar 16, 2022
SIG-Windows automation moved this from In Progress (v1.24) to Done (v1.24) Mar 16, 2022
@k8s-ci-robot
Copy link
Contributor

@Abirdcfly: you can only set the release note label to release-note-none if the release-note block in the PR body text is empty or "none".

In response to this:

/release-note-none

just change changelog

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link
Contributor

@Abirdcfly: /release-note-edit must be used with a release note block.

In response to this:

/release-note-edit

none

(just a minor edit)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Abirdcfly
Copy link
Member

Abirdcfly commented Mar 26, 2022 •
edited

/release-note-edit

NONE

(RN is not needed, I guess.And my first time using this PR comment😂, All 3 of my attempts have failed and we need an expert to deal with this problem now. 🤦‍♂️

The problem is that No (#108432, @iXinqi) [SIG Testing and Windows] doesn't seem to be in CHANGELOG)

@k8s-ci-robot
Copy link
Contributor

@Abirdcfly: /release-note-edit must be used with a release note block.

In response to this:

/release-note-edit

NONE

(RN is not needed, I guess.And my first time using this PR comment😂)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Abirdcfly
Copy link
Member

/release-note-none

@k8s-ci-robot
Copy link
Contributor

@Abirdcfly: you can only set the release note label to release-note-none if the release-note block in the PR body text is empty or "none".

In response to this:

/release-note-none

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Abirdcfly Abirdcfly mentioned this pull request Apr 22, 2022
Merged
@invidian
Copy link
Member

invidian commented May 3, 2022

The problem is that No (#108432, @iXinqi) [SIG Testing and Windows] doesn't seem to be in CHANGELOG)

It is now it seems though 😄 https://github.com/kubernetes/kubernetes/blob/master/CHANGELOG/CHANGELOG-1.24.md#feature

@iXinqi iXinqi mentioned this pull request Jul 20, 2022
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsturtevant jsturtevant jsturtevant requested changes

@marosset marosset marosset left review comments

@knabben knabben knabben approved these changes

@feiskyer feiskyer Awaiting requested review from feiskyer

Assignees

@jsturtevant jsturtevant

@marosset marosset

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/testing Categorizes an issue or PR as relevant to SIG Testing. sig/windows Categorizes an issue or PR as relevant to SIG Windows. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG-Windows
  
Done (v1.24)
Milestone
v1.24
Development

Successfully merging this pull request may close these issues.

Add an e2e test for UNC paths windows when using gMSA
8 participants
@iXinqi @k8s-ci-robot @k8s-triage-robot @knabben @jsturtevant @marosset @Abirdcfly @invidian