Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add the grpc-health-checking to agnhost #108500

Merged
merged 1 commit into from
Mar 10, 2022
Merged

add the grpc-health-checking to agnhost #108500

merged 1 commit into from
Mar 10, 2022

Conversation

SergeyKanzhelev
Copy link
Member

/kind feature
/sig node
/sig testing

What this PR does / why we need it:

In order to better test GRPC probes (kubernetes/enhancements#2727) and do not require heavy etcd image for e2e, this small addition to agnhost will be very handy.

Does this PR introduce a user-facing change?

NONE

KEP: kubernetes/enhancements#2727

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/feature Categorizes issue or PR as related to a new feature. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Mar 3, 2022
@k8s-ci-robot
Copy link
Contributor

@SergeyKanzhelev: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/test labels Mar 3, 2022
@SergeyKanzhelev SergeyKanzhelev force-pushed the grpcsupportInAgnHost branch 3 times, most recently from 0596fd2 to 00fa1ec Compare March 4, 2022 00:28
@SergeyKanzhelev SergeyKanzhelev mentioned this pull request Mar 4, 2022
Merged
@SergeyKanzhelev
Copy link
Member Author

/retest

aojea
aojea reviewed Mar 4, 2022
View reviewed changes
test/images/agnhost/VERSION Outdated Show resolved Hide resolved
@aojea
Copy link
Member

aojea commented Mar 4, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 4, 2022
@SergeyKanzhelev
Copy link
Member Author

/retest

@aojea
Copy link
Member

aojea commented Mar 4, 2022

/approve
/hold
I think that is safe to approve here, but I'll keep the hold if you want anybody else to look into it
Feel free to unhold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 4, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aojea, SergeyKanzhelev

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 4, 2022
@SergeyKanzhelev
Copy link
Member Author

@aojea do you know if the image will be published automatically once merged?

@aojea
Copy link
Member

aojea commented Mar 5, 2022

@aojea do you know if the image will be published automatically once merged?

nope, it has to be promoted

kubernetes/k8s.io@e66ab6d

https://github.com/kubernetes/kubernetes/tree/master/test/images#promoting-images

@SergeyKanzhelev
Copy link
Member Author

/unhold

no more takers for review, proceeding

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 10, 2022
@k8s-ci-robot k8s-ci-robot merged commit 425ff1c into kubernetes:master Mar 10, 2022
SIG Node CI/Test Board automation moved this from Triage to Done Mar 10, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.24 milestone Mar 10, 2022
SIG Node PR Triage automation moved this from Triage to Done Mar 10, 2022
@SergeyKanzhelev SergeyKanzhelev deleted the grpcsupportInAgnHost branch March 15, 2022 04:07
SergeyKanzhelev added a commit to SergeyKanzhelev/k8s.io that referenced this pull request Mar 15, 2022
@SergeyKanzhelev
Update agnhost to pick up the grpc probe command
e43463b 
From kubernetes/kubernetes#108500

Digest is from:

```
docker run --rm mplatform/mquery gcr.io/k8s-staging-e2e-test-images/agnhost:2.35
Unable to find image 'mplatform/mquery:latest' locally
latest: Pulling from mplatform/mquery
f7727aa0d57a: Pull complete 
2db63f065e4b: Pull complete 
Digest: sha256:d0989420b6f0d2b929fd9355f15c767f62d0e9a72cdf999d1eb16e6073782c71
Status: Downloaded newer image for mplatform/mquery:latest
Image: gcr.io/k8s-staging-e2e-test-images/agnhost:2.35 (digest: sha256:3c5f7db4be8501eca4c5d0ce7bb3a1d890ce5b6ccfbe4db6fef7d9705a6b4434)
 * Manifest List: Yes (Image type: application/vnd.docker.distribution.manifest.list.v2+json)
 * Supported platforms:
   - linux/amd64
   - linux/arm/v7
   - linux/arm64
   - linux/ppc64le
   - linux/s390x
   - windows/amd64:10.0.17763.2686
   - windows/amd64:10.0.19042.1586
   - windows/amd64:10.0.20348.587
```

Tested locally: `docker run -i -p 8080:8080 -p 5000:5000 gcr.io/k8s-staging-e2e-test-i-images/agnhost:2.35   grpc-health-checking`
@SergeyKanzhelev SergeyKanzhelev mentioned this pull request Mar 15, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aojea aojea aojea left review comments

@johnSchnake johnSchnake Awaiting requested review from johnSchnake

@mkumatag mkumatag Awaiting requested review from mkumatag

Assignees

@aojea aojea

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
SIG Node CI/Test Board
Done
SIG Node CI/Test Board
Archived in project
SIG Node PR Triage
Archived in project
SIG Node PR Triage
Done
Milestone
v1.24
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@SergeyKanzhelev @k8s-ci-robot @aojea