Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mount-utils: Add support for btrfs resize #108561

Merged
merged 1 commit into from
Mar 14, 2022

Conversation

RomanBednar
Copy link
Contributor

@RomanBednar RomanBednar commented Mar 7, 2022

Mount utils support resizing of btrfs volume, however it lacks btrfs
device block size and total size detection needed to determine if
resize is needed.

What type of PR is this?

/kind feature

What this PR does / why we need it:

Adding btrfs support is useful for certain CSI drivers (e.g. Azure)
which now have to implement custom solution for btrfs resize.

With this patch it should be easy for such drivers to use mount-utils
module instead and help unify (and correct) the resize flows.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Added support for btrfs resizing

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


Mount utils support resizing of btrfs volume, however it lacks btrfs
device block size and total size detection needed to determine if
resize is needed.

Adding btrfs support is useful for certain CSI drivers (e.g. Azure)
which now have to implement custom solution for btrfs resize.

With this patch it should be easy for such drivers to use mount-utils
module instead and help unify (and correct) the resize flows.
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/feature Categorizes issue or PR as related to a new feature. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Mar 7, 2022
@k8s-ci-robot
Copy link
Contributor

@RomanBednar: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Mar 7, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @RomanBednar. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added sig/storage Categorizes an issue or PR as relevant to SIG Storage. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Mar 7, 2022
Copy link
Member

@andyzhangx andyzhangx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 7, 2022
@RomanBednar
Copy link
Contributor Author

/retest

@jsafrane
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 14, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsafrane, RomanBednar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 14, 2022
@k8s-ci-robot k8s-ci-robot merged commit 7f1907c into kubernetes:master Mar 14, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.24 milestone Mar 14, 2022
@jberkus
Copy link

jberkus commented Mar 15, 2022

This feature feels like it should have a release note.

@AuraSinis

@AuraSinis
Copy link

AuraSinis commented Mar 15, 2022

Thank you @jberkus
@RomanBednar does this only concern CSPs? Either way a release note would be nice.

Would "Added support for btrfs resizing" be sufficient, or is more detail needed?

@k8s-ci-robot k8s-ci-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Mar 16, 2022
@k8s-ci-robot k8s-ci-robot removed the release-note-none Denotes a PR that doesn't merit a release note. label Mar 16, 2022
@RomanBednar
Copy link
Contributor Author

RomanBednar commented Mar 16, 2022

@AuraSinis I think so, I've posted this patch so we can properly implement volume resizing in Azure CSI driver. Not sure how, or if other CSPs are concerned. This effort is tracked here and applies to all CSI drivers. So in order for Azure to use mount-utils this patch was required - hope that explains the situation well.

I've also added a short release note as requested.

@andyzhangx
Copy link
Member

andyzhangx commented Mar 17, 2022

@AuraSinis I think so, I've posted this patch so we can properly implement volume resizing in Azure CSI driver. Not sure how, or if other CSPs are concerned. This effort is tracked here and applies to all CSI drivers. So in order for Azure to use mount-utils this patch was required - hope that explains the situation well.

I've also added a short release note as requested.

@RomanBednar here is the PR for azure disk csi driver support on btrfs resize: kubernetes-sigs/azuredisk-csi-driver#1225, it just upgrade mount-utils vendor packages.

@RomanBednar
Copy link
Contributor Author

@RomanBednar here is the PR for azure disk csi driver support on btrfs resize: kubernetes-sigs/azuredisk-csi-driver#1225, it just upgrade mount-utils vendor packages.

@andyzhangx Awesome, thanks for letting me know. I'll wait for it to merge and then proceed with my planned patch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants