-
Notifications
You must be signed in to change notification settings - Fork 38.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mount-utils: Add support for btrfs resize #108561
Conversation
Mount utils support resizing of btrfs volume, however it lacks btrfs device block size and total size detection needed to determine if resize is needed. Adding btrfs support is useful for certain CSI drivers (e.g. Azure) which now have to implement custom solution for btrfs resize. With this patch it should be easy for such drivers to use mount-utils module instead and help unify (and correct) the resize flows.
@RomanBednar: This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Hi @RomanBednar. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ok-to-test
/retest |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jsafrane, RomanBednar The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This feature feels like it should have a release note. |
Thank you @jberkus Would "Added support for btrfs resizing" be sufficient, or is more detail needed? |
@AuraSinis I think so, I've posted this patch so we can properly implement volume resizing in Azure CSI driver. Not sure how, or if other CSPs are concerned. This effort is tracked here and applies to all CSI drivers. So in order for Azure to use mount-utils this patch was required - hope that explains the situation well. I've also added a short release note as requested. |
@RomanBednar here is the PR for azure disk csi driver support on btrfs resize: kubernetes-sigs/azuredisk-csi-driver#1225, it just upgrade mount-utils vendor packages. |
@andyzhangx Awesome, thanks for letting me know. I'll wait for it to merge and then proceed with my planned patch. |
Mount utils support resizing of btrfs volume, however it lacks btrfs
device block size and total size detection needed to determine if
resize is needed.
What type of PR is this?
/kind feature
What this PR does / why we need it:
Adding btrfs support is useful for certain CSI drivers (e.g. Azure)
which now have to implement custom solution for btrfs resize.
With this patch it should be easy for such drivers to use mount-utils
module instead and help unify (and correct) the resize flows.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: