topology translation of in-tree vSphere volume to vSphere CSI

[divyenpatel]

What type of PR is this?

/kind bug

Optionally add one or more of the following kinds if applicable:
/kind regression

What this PR does / why we need it:

vSphere CSI driver does not understand legacy topology labels in-tree vSphere plugin is using.
This PR is adding topology translation from in-tree vSphere volume to vSphere CSI.

This PR is translating topology GA/topology beta labels to topology.csi.vmware.com/region and topology.csi.vmware.com/zone.

Special notes for your reviewer:

Pre-req for topology translation support.
vSphere CSI Driver must be installed using following vSphere Config Secret

[Labels]
region = k8s-region
zone = k8s-zone
[TopologyCategory "k8s-region"]
Label = "topology.csi.vmware.com/region"
[TopologyCategory "k8s-zone"]
Label = "topology.csi.vmware.com/zone"

Unit test execution

% go test -v -run  TestTranslatevSphereInTreeStorageClassToCSI
=== RUN   TestTranslatevSphereInTreeStorageClassToCSI
    vsphere_volume_test.go:113: Testing expect error when sc is nil
    vsphere_volume_test.go:113: Testing translate with no parameter
    vsphere_volume_test.go:113: Testing translate with unknown parameter
    vsphere_volume_test.go:113: Testing translate with storagepolicyname and datastore
    vsphere_volume_test.go:113: Testing translate with fstype
    vsphere_volume_test.go:113: Testing translate with storagepolicyname and fstype
    vsphere_volume_test.go:113: Testing translate with no parameter and allowedTopology
    vsphere_volume_test.go:113: Testing translate with storagepolicyname and allowedTopology
    vsphere_volume_test.go:113: Testing translate with storagepolicyname and allowedTopology beta labels
    vsphere_volume_test.go:113: Testing translate with raw vSAN policy parameters, datastore and diskformat
    vsphere_volume_test.go:113: Testing translate with all parameters
--- PASS: TestTranslatevSphereInTreeStorageClassToCSI (0.00s)
PASS
ok      k8s.io/csi-translation-lib/plugins      0.381s

 % go test -v -run  TestTranslateVSphereInTreePVToCSI
=== RUN   TestTranslateVSphereInTreePVToCSI
    vsphere_volume_test.go:464: Testing expect error when in-tree vsphere PV is nil
    vsphere_volume_test.go:464: Testing translate valid vSphere in-tree PV to vSphere CSI PV
    vsphere_volume_test.go:464: Testing translate valid vSphere in-tree PV with beta topology labels to vSphere CSI PV
    vsphere_volume_test.go:464: Testing translate valid vSphere in-tree PV with GA topology labels to vSphere CSI PV
--- PASS: TestTranslateVSphereInTreePVToCSI (0.00s)
PASS
ok      k8s.io/csi-translation-lib/plugins      0.178s

% go test -v -run  TestTranslateVSphereCSIPVToInTree
=== RUN   TestTranslateVSphereCSIPVToInTree
    vsphere_volume_test.go:276: Testing expect error when pv is nil
    vsphere_volume_test.go:276: Testing expect error when pv.Spec.CSI is nil
    vsphere_volume_test.go:276: Testing translate valid vSphere CSI PV to vSphere in-tree PV
    vsphere_volume_test.go:276: Testing translate valid vSphere CSI PV with topology Node Affinity rules to vSphere CSI PV with topology labels
--- PASS: TestTranslateVSphereCSIPVToInTree (0.00s)
PASS
ok      k8s.io/csi-translation-lib/plugins      0.365s

Does this PR introduce a user-facing change?

topology translation of in-tree vSphere volume to vSphere CSI.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

[k8s-ci-robot]

@divyenpatel: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[divyenpatel]

@shalini-b I have addressed your review comments here - 7aa4379

[shalini-b]

/approve

[xing-yang]

/lgtm

[xing-yang]

/assign @msau42 @Jiawei0227

[xing-yang]

/assign @gnufied

[msau42]

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: divyenpatel, msau42, shalini-b

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• staging/src/k8s.io/csi-translation-lib/OWNERS [msau42]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-triage-robot]

The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass.

This bot retests PRs for certain kubernetes repos according to the following rules:

• The PR does have any do-not-merge/* labels
• The PR does not have the needs-ok-to-test label
• The PR is mergeable (does not have a needs-rebase label)
• The PR is approved (has cncf-cla: yes, lgtm, approved labels)
• The PR is failing tests required for merge

You can:

• Review the full test history for this PR
• Prevent this bot from retesting with /lgtm cancel or /hold
• Help make our tests less flaky by following our Flaky Tests Guide

/retest