Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the "CSRDuration" feature gate in Kube v1.26 #108814

Closed
cfryanr opened this issue Mar 18, 2022 · 7 comments · Fixed by #112386
Closed

Remove the "CSRDuration" feature gate in Kube v1.26 #108814

cfryanr opened this issue Mar 18, 2022 · 7 comments · Fixed by #112386
Assignees
@Shubham82
Labels
kind/feature Categorizes issue or PR as related to a new feature. sig/auth Categorizes an issue or PR as relevant to SIG Auth. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Auth Old
Milestone
v1.26

Comments

@cfryanr
Copy link
Contributor

cfryanr commented Mar 18, 2022 •
edited

What would you like to be added?

Remove the "CSRDuration" feature gate starting in Kube v1.26.

Why is this needed?

PR #108782 proposes that the CertificateSigningRequest's Spec.ExpirationSeconds field be promoted to GA in v1.24. It was originally introduced as beta in v1.22 with a corresponding feature gate called "CSRDuration" to optionally disable it (see PR #99494).

If PR #108782 is merged and included in v1.24, then in v1.26 the "CSRDuration" feature gate should be removed.

See also #108782 (comment) where a member of SIG-auth asked me to create this issue.
@cfryanr cfryanr added the kind/feature Categorizes issue or PR as related to a new feature. label Mar 18, 2022
@k8s-ci-robot k8s-ci-robot added needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Mar 18, 2022
@cfryanr cfryanr mentioned this issue Mar 18, 2022
Merged
@cfryanr cfryanr changed the title Remove the "CSRDuration" feature gate in Kube v.126 Remove the "CSRDuration" feature gate in Kube v1.26 Mar 18, 2022
@cfryanr
Copy link
Contributor Author

cfryanr commented Mar 18, 2022

/sig auth

@k8s-ci-robot k8s-ci-robot added sig/auth Categorizes an issue or PR as relevant to SIG Auth. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Mar 18, 2022
@enj enj added this to Needs Triage in SIG Auth Old Mar 21, 2022
@enj
Copy link
Member

enj commented Mar 21, 2022

/triage accepted
/milestone v1.26

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Mar 21, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.26 milestone Mar 21, 2022
@enj enj moved this from Needs Triage to Backlog in SIG Auth Old Mar 21, 2022
@kl52752
Copy link
Contributor

kl52752 commented Apr 23, 2022

Is this task a good first issue? I would like to be assign to it.

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 22, 2022
@cfryanr
Copy link
Contributor Author

cfryanr commented Jul 22, 2022

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 22, 2022
@Shubham82
Copy link
Contributor

I'd like to work on this!
/assign

@Shubham82 Shubham82 mentioned this issue Sep 12, 2022
Merged
@Shubham82
Copy link
Contributor

Fixed it here: #112386

SIG Auth Old automation moved this from Backlog to Closed / Done Sep 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Shubham82 Shubham82

Labels
kind/feature Categorizes issue or PR as related to a new feature. sig/auth Categorizes an issue or PR as relevant to SIG Auth. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Auth
Archived in project
SIG Auth Old
Closed / Done
Milestone
v1.26
Development

Successfully merging a pull request may close this issue.

Remove CSRDuration feature gate. Shubham82/kubernetes
6 participants
@enj @k8s-ci-robot @cfryanr @Shubham82 @k8s-triage-robot @kl52752