Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend example to contain --as=... #108835

Merged
merged 1 commit into from Jan 30, 2023
Merged

Extend example to contain --as=... #108835

merged 1 commit into from Jan 30, 2023

Conversation

guettli
Copy link
Contributor

@guettli guettli commented Mar 20, 2022

What type of PR is this?

This PR extends the help message of kubectl auth can-i -h

It adds --as==system:serviceaccount:default:foo to the example.

I struggled to find the right syntax for --as=... so I think this will
help new comers.

/kind documentation

What this PR does / why we need it:

We want Kubernetes to be easy to understand.

Does this PR introduce a user-facing change?


NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/documentation Categorizes issue or PR as related to documentation. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Mar 20, 2022
@k8s-ci-robot
Copy link
Contributor

@guettli: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link
Contributor

Hi @guettli. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 20, 2022
@guettli guettli changed the title Extend example to contain --as==... Extend example to contain --as=... Mar 20, 2022
@k8s-ci-robot k8s-ci-robot added area/kubectl sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/cli Categorizes an issue or PR as relevant to SIG CLI. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Mar 20, 2022
@enj enj added this to Needs Triage in SIG Auth Old Mar 21, 2022
@RyanAoh
Copy link
Member

RyanAoh commented Mar 23, 2022

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 23, 2022
@guettli
Copy link
Contributor Author

guettli commented Mar 23, 2022

/test pull-kubernetes-integration

/test pull-kubernetes-verify

slaskawi
slaskawi approved these changes Apr 4, 2022
View reviewed changes
Copy link
Contributor

@slaskawi slaskawi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot
Copy link
Contributor

@slaskawi: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@RyanAoh
Copy link
Member

RyanAoh commented Apr 29, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 29, 2022
@ritazh
Copy link
Member

ritazh commented Jul 25, 2022

/assign @mikedanese

@ritazh ritazh moved this from Needs Triage to In Review in SIG Auth Old Jul 25, 2022
@guettli
Copy link
Contributor Author

guettli commented Oct 17, 2022

@mikedanese could you please have a look at this small MR?

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 15, 2023
@guettli
Copy link
Contributor Author

guettli commented Jan 16, 2023

@RyanAoh is there anything I can do, to get this small change merged?

@RyanAoh
Copy link
Member

RyanAoh commented Jan 16, 2023

@RyanAoh is there anything I can do, to get this small change merged?

Perhaps you can use the #sig-auth channel on Slack to get help finding approvers.

liggitt
liggitt reviewed Jan 18, 2023
View reviewed changes
staging/src/k8s.io/kubectl/pkg/cmd/auth/cani.go Outdated
# Check to see if I can list deployments in my current namespace
kubectl auth can-i list deployments.apps
# Check to see if service account "foo" can list deployments in the current namespace
kubectl auth can-i list deployments.apps --as==system:serviceaccount:default:foo
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few suggestions:

  • add the impersonation example alongside the existing one rather than changing it
  • note that it uses impersonation, so you must be authorized to impersonate that service account
  • update the syntax to be --as=... (no double-equal)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@liggitt thank you for your feedback. I updated the PR. Is it ok now?

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 29, 2023
@k8s-ci-robot k8s-ci-robot added the do-not-merge/contains-merge-commits Indicates a PR which contains merge commits. label Jan 29, 2023
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/contains-merge-commits Indicates a PR which contains merge commits. label Jan 29, 2023
@guettli guettli requested review from liggitt and removed request for mikedanese, deads2k and RyanAoh January 29, 2023 18:43
@liggitt
Copy link
Member

liggitt commented Jan 30, 2023

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 30, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: guettli, liggitt, slaskawi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: f83ef0e23dcf93bee6b00996551b8e79d095f937

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 30, 2023
@k8s-ci-robot k8s-ci-robot merged commit 4198d66 into kubernetes:master Jan 30, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.27 milestone Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slaskawi slaskawi slaskawi approved these changes

@liggitt liggitt Awaiting requested review from liggitt

Assignees

@liggitt liggitt

@mikedanese mikedanese

@RyanAoh RyanAoh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubectl cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/cli Categorizes an issue or PR as relevant to SIG CLI. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
SIG Auth
Archived in project
SIG Auth Old
In Review
Milestone
v1.27
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@guettli @k8s-ci-robot @RyanAoh @ritazh @k8s-triage-robot @liggitt @slaskawi @mikedanese