Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: implement node inclusion policy in scheduler #108884

Merged
merged 1 commit into from May 11, 2022
Merged

feat: implement node inclusion policy in scheduler #108884

merged 1 commit into from May 11, 2022

Conversation

kerthcet
Copy link
Member

What type of PR is this?

/kind feature
/sig scheduling

What this PR does / why we need it:

Which issue(s) this PR fixes:

Part of kubernetes/enhancements#3094

Special notes for your reviewer:

Does this PR introduce a user-facing change?

None

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

- [KEP]: https://github.com/kubernetes/enhancements/issues/3094

@kerthcet
Copy link
Member Author

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Mar 22, 2022
@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. kind/feature Categorizes issue or PR as related to a new feature. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Mar 22, 2022
@k8s-ci-robot k8s-ci-robot added area/code-generation kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/apps Categorizes an issue or PR as relevant to SIG Apps. labels Mar 22, 2022
@kerthcet
Copy link
Member Author

kerthcet commented Mar 22, 2022 •
edited

More unit tests should be covered, otherwise the feature it's completed. (in case someone would like to review this first for close to code freeze)

@kerthcet kerthcet force-pushed the feature/implement-nodeInclusionPolicy branch from bfe2be3 to 66b0dbc Compare March 22, 2022 18:10
@kerthcet
Copy link
Member Author

/retest

@kerthcet kerthcet marked this pull request as ready for review March 22, 2022 18:19
@kerthcet kerthcet changed the title implement node inclusion policy [WIP]implement node inclusion policy Mar 22, 2022
@k8s-ci-robot k8s-ci-robot added area/test sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Mar 22, 2022
@kerthcet kerthcet force-pushed the feature/implement-nodeInclusionPolicy branch from 66b0dbc to 5e4c8a7 Compare March 22, 2022 18:43
@fedebongio
Copy link
Contributor

/sig node
/remove-sig api-machinery

@k8s-ci-robot k8s-ci-robot added sig/node Categorizes an issue or PR as relevant to SIG Node. and removed sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. labels Mar 22, 2022
@kerthcet
Copy link
Member Author

kerthcet commented May 9, 2022

/retest

@kerthcet kerthcet mentioned this pull request May 9, 2022
Closed
@kerthcet
Copy link
Member Author

kerthcet commented May 9, 2022

/retest

@alculquicondor
Copy link
Member

/approve
/lgtm
/hold
for the API change to merge first.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 9, 2022
@kerthcet kerthcet force-pushed the feature/implement-nodeInclusionPolicy branch from 6b21109 to d87bafb Compare May 10, 2022 07:48
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 10, 2022
@kerthcet
Copy link
Member Author

kerthcet commented May 10, 2022 •
edited

cc @alculquicondor @liggitt api part has been merged.

@alculquicondor
Copy link
Member

Please rebase.

@kerthcet
feat: implement NodeInclusionPolicy in TopologySpreadConstraint
790d983 
Signed-off-by: kerthcet <kerthcet@gmail.com>
@kerthcet kerthcet force-pushed the feature/implement-nodeInclusionPolicy branch from d87bafb to 790d983 Compare May 10, 2022 23:52
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alculquicondor, kerthcet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 10, 2022
@kerthcet
Copy link
Member Author

/retest

2 similar comments
@kerthcet
Copy link
Member Author

/retest

@kerthcet
Copy link
Member Author

/retest

@kerthcet
Copy link
Member Author

still need a lgtm @alculquicondor @Huang-Wei

@alculquicondor
Copy link
Member

Did you file a bugs for the flaky tests?

alculquicondor
alculquicondor reviewed May 11, 2022
View reviewed changes
Copy link
Member

@alculquicondor alculquicondor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 11, 2022
@kerthcet
Copy link
Member Author

Did you file a bugs for the flaky tests?

I tracked the flaky test here #109223 (comment), but I haven't time to dig into the problem.

@kerthcet
Copy link
Member Author

Do you hold this PR for special reason @alculquicondor ?

@alculquicondor
Copy link
Member

/hold cancel
it was just because the API was not merged yet.

Please don't forget to fix the 2 doc comments in the v1 package.

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 11, 2022
@kerthcet
Copy link
Member Author

/hold cancel it was just because the API was not merged yet.

Please don't forget to fix the 2 doc comments in the v1 package.

already on the way. Thanks for reminding

@kerthcet
Copy link
Member Author

/retest

@k8s-ci-robot k8s-ci-robot merged commit 3bcbf3d into kubernetes:master May 11, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.25 milestone May 11, 2022
@kerthcet kerthcet deleted the feature/implement-nodeInclusionPolicy branch May 11, 2022 15:47
@github-actions github-actions bot mentioned this pull request May 17, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liggitt liggitt liggitt left review comments

@alculquicondor alculquicondor alculquicondor left review comments

@Huang-Wei Huang-Wei Huang-Wei left review comments

@denkensk denkensk denkensk left review comments

@ahg-g ahg-g Awaiting requested review from ahg-g

@dchen1107 dchen1107 Awaiting requested review from dchen1107

Assignees

@alculquicondor alculquicondor

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/code-generation area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.25
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@kerthcet @k8s-ci-robot @fedebongio @alculquicondor @k8s-triage-robot @Huang-Wei @cici37 @liggitt @denkensk